RESOLVED FIXED 98716
[EFL] Use ewk_view_paint instead of ewk_view_paint_contents in ewk_view_single. 
https://bugs.webkit.org/show_bug.cgi?id=98716
Summary [EFL] Use ewk_view_paint instead of ewk_view_paint_contents in ewk_view_single.
Ryuan Choi
Reported 2012-10-08 21:18:21 PDT
ewk_view_paint is the wrapper of ScrollView::paint and ewk_view_paint_contents is the wrapper of FrameView::paintContents. Because FrameView::paintContents just draw contents, ewk_view_single should use ewk_view_paint instead of ewk_view_paint_contents like other ports.
Attachments
Patch (3.58 KB, patch)
2012-10-08 21:26 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2012-10-08 21:26:01 PDT
Created attachment 167683 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-10-10 00:59:09 PDT
Comment on attachment 167683 [details] Patch why we still working on webkit1?
Gyuyoung Kim
Comment 3 2012-10-10 01:31:38 PDT
(In reply to comment #2) > (From update of attachment 167683 [details]) > why we still working on webkit1? Though our target is WK2 EFL, WK1 EFL may be used by other applications in future. IMO, we sometimes need to maintain WK1 until we remove this in trunk.
Ryuan Choi
Comment 4 2012-10-10 03:36:12 PDT
Comment on attachment 167683 [details] Patch Although I am interested in wk1/efl yet, I want to refactor this as one of steps to enable pixel-tests. With this, I can fix DRT and rebase some of pixel tests.
WebKit Review Bot
Comment 5 2012-10-10 03:40:49 PDT
Comment on attachment 167683 [details] Patch Clearing flags on attachment: 167683 Committed r130881: <http://trac.webkit.org/changeset/130881>
WebKit Review Bot
Comment 6 2012-10-10 03:40:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.