Bug 98716 - [EFL] Use ewk_view_paint instead of ewk_view_paint_contents in ewk_view_single.
Summary: [EFL] Use ewk_view_paint instead of ewk_view_paint_contents in ewk_view_single.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-08 21:18 PDT by Ryuan Choi
Modified: 2012-10-10 03:40 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.58 KB, patch)
2012-10-08 21:26 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2012-10-08 21:18:21 PDT 
ewk_view_paint is the wrapper of ScrollView::paint and
ewk_view_paint_contents is the wrapper of FrameView::paintContents.

Because FrameView::paintContents just draw contents,
ewk_view_single should use ewk_view_paint instead of ewk_view_paint_contents
like other ports.
Comment 1 Ryuan Choi 2012-10-08 21:26:01 PDT 
Created attachment 167683 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-10-10 00:59:09 PDT 
Comment on attachment 167683 [details]
Patch

why we still working on webkit1?
Comment 3 Gyuyoung Kim 2012-10-10 01:31:38 PDT 
(In reply to comment #2)
> (From update of attachment 167683 [details])
> why we still working on webkit1?

Though our target is WK2 EFL, WK1 EFL may be used by other applications in future. IMO, we sometimes need to maintain WK1 until we remove this in trunk.
Comment 4 Ryuan Choi 2012-10-10 03:36:12 PDT 
Comment on attachment 167683 [details]
Patch

Although I am interested in wk1/efl yet, I want to refactor this as one of steps to enable pixel-tests.

With this, I can fix DRT and rebase some of pixel tests.
Comment 5 WebKit Review Bot 2012-10-10 03:40:49 PDT 
Comment on attachment 167683 [details]
Patch

Clearing flags on attachment: 167683

Committed r130881: <http://trac.webkit.org/changeset/130881>
Comment 6 WebKit Review Bot 2012-10-10 03:40:54 PDT 
All reviewed patches have been landed.  Closing bug.