Bug 98714 – [Chromium] Add WebElement::hasHTMLTagName, and deprecate hasTagName

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kent Tamura]

[Chromium] Add WebElement::hasHTMLTagName, and deprecate hasTagName

[Kent Tamura]

Created attachment 167679 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Kent Tamura]

(In reply to comment #2)
> Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] 

Could anyone approve this please?

[Adam Barth]

Comment on attachment 167679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167679&action=review

API change LGTM

> Source/WebKit/chromium/src/WebElement.cpp:70
> +    return HTMLNames::xhtmlNamespaceURI == element->namespaceURI() && equalIgnoringCase(element->tagName(), tagName.operator String());

tagName.operator String()   ->  String(tagName) might be a prettier way to write this.

[Adam Barth]

> Could anyone approve this please?

tkent: Given that you're one of our API reviewers, I think it's fine for you to change the API with just a normal review.  After all, fishd used to change the API all the time when he was the only API reviewer.  :)

[Kent Tamura]

Committed r130847: <http://trac.webkit.org/changeset/130847>