Bug 98714 - [Chromium] Add WebElement::hasHTMLTagName, and deprecate hasTagName
Summary: [Chromium] Add WebElement::hasHTMLTagName, and deprecate hasTagName
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-08 20:44 PDT by Kent Tamura
Modified: 2012-10-09 22:07 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.95 KB, patch)
2012-10-08 20:50 PDT, Kent Tamura 		inferno: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-10-08 20:44:22 PDT 
[Chromium] Add WebElement::hasHTMLTagName, and deprecate hasTagName
Comment 1 Kent Tamura 2012-10-08 20:50:51 PDT 
Created attachment 167679 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-08 20:54:43 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Kent Tamura 2012-10-09 21:49:48 PDT 
(In reply to comment #2)
> Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org 

Could anyone approve this please?
Comment 4 Adam Barth 2012-10-09 21:58:30 PDT 
Comment on attachment 167679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167679&action=review

API change LGTM

> Source/WebKit/chromium/src/WebElement.cpp:70
> +    return HTMLNames::xhtmlNamespaceURI == element->namespaceURI() && equalIgnoringCase(element->tagName(), tagName.operator String());

tagName.operator String()   ->  String(tagName) might be a prettier way to write this.
Comment 5 Adam Barth 2012-10-09 21:59:38 PDT 
> Could anyone approve this please?

tkent: Given that you're one of our API reviewers, I think it's fine for you to change the API with just a normal review.  After all, fishd used to change the API all the time when he was the only API reviewer.  :)
Comment 6 Kent Tamura 2012-10-09 22:07:09 PDT 
Committed r130847: <http://trac.webkit.org/changeset/130847>