Bug 98709 - [Chromium] Alpha channel support in WebVideoFrame
Summary: [Chromium] Alpha channel support in WebVideoFrame
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-08 18:44 PDT by jfaust
Modified: 2013-04-08 15:15 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2012-10-08 19:01 PDT, jfaust 		no flags Details | Formatted Diff | Diff
Accommodate alpha planes (1.86 KB, patch)
2012-10-09 14:36 PDT, jfaust 		no flags Details | Formatted Diff | Diff
Accommodate alpha planes (1.91 KB, patch)
2012-10-09 14:43 PDT, jfaust 		benjamin: review-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jfaust 2012-10-08 18:44:14 PDT 
Adds support for an alpha plane to the WebVideoFrame class. Increases the maximum number of planes and adds another plane type for alpha data.
Comment 1 jfaust 2012-10-08 19:01:33 PDT 
Created attachment 167670 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-08 19:03:56 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 James Robinson 2012-10-08 22:11:30 PDT 
Comment on attachment 167670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167670&action=review

> Source/Platform/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

You have to put something here.  I'd suggest describing the new values and when they are used.
Comment 4 jfaust 2012-10-09 14:36:12 PDT 
Created attachment 167850 [details]
Accommodate alpha planes
Comment 5 WebKit Review Bot 2012-10-09 14:38:28 PDT 
Attachment 167850 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/Platform/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/Platform/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Source/Platform/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Source/Platform/ChangeLog:12:  Line contains tab character.  [whitespace/tab] [5]
Source/Platform/ChangeLog:13:  Line contains tab character.  [whitespace/tab] [5]
Source/Platform/ChangeLog:14:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 6 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 jfaust 2012-10-09 14:43:12 PDT 
Created attachment 167852 [details]
Accommodate alpha planes
Comment 7 James Robinson 2012-10-11 12:58:20 PDT 
Comment on attachment 167852 [details]
Accommodate alpha planes

View in context: https://bugs.webkit.org/attachment.cgi?id=167852&action=review

> Source/Platform/ChangeLog:14
> +        Y plane. The existing enum constant numYUVPlanes becomes somewhat
> +        misleading as it now counts YUV planes as well as an A plane.

Why not fix it or add a new value for YUVA?