Bug 98706 - results.html and garden-o-matic are ignoring IMAGE failures when expected to FAIL
Summary: results.html and garden-o-matic are ignoring IMAGE failures when expected to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-08 17:36 PDT by Dirk Pranke
Modified: 2012-10-09 09:36 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.95 KB, patch)
2012-10-08 17:38 PDT, Dirk Pranke 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-10-08 17:36:03 PDT 
results.html and garden-o-matic are ignoring IMAGE failures when expected to FAIL
Comment 1 Dirk Pranke 2012-10-08 17:38:38 PDT 
Created attachment 167658 [details]
Patch
Comment 2 Ojan Vafai 2012-10-08 18:11:24 PDT 
Comment on attachment 167658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167658&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:151
> +            if (childName.indexOf("radialGradient") != -1)
> +               1;

Accidentally included?
Comment 3 Dirk Pranke 2012-10-08 18:32:38 PDT 
(In reply to comment #2)
> (From update of attachment 167658 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167658&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:151
> > +            if (childName.indexOf("radialGradient") != -1)
> > +               1;
> 
> Accidentally included?

Whoops. Yup.
Comment 4 Dirk Pranke 2012-10-08 18:36:16 PDT 
Committed r130709: <http://trac.webkit.org/changeset/130709>
Comment 5 Csaba Osztrogonác 2012-10-09 00:18:33 PDT 
(In reply to comment #4)
> Committed r130709: <http://trac.webkit.org/changeset/130709>

And expected update landed in r130727: <http://trac.webkit.org/changeset/130727>
Comment 6 Dirk Pranke 2012-10-09 09:36:46 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > Committed r130709: <http://trac.webkit.org/changeset/130709>
> 
> And expected update landed in r130727: <http://trac.webkit.org/changeset/130727>

Whoops, thanks, Ossy!