Bug 98703 - Inline logicalHeightForRowSizing to shave another 2-3% off robohornet's resizecol.html
Summary: Inline logicalHeightForRowSizing to shave another 2-3% off robohornet's resiz...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 98798
  Show dependency tree / graph
 
Reported: 2012-10-08 17:16 PDT by Eric Seidel (no email)
Modified: 2012-10-09 11:20 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.29 KB, patch)
2012-10-08 17:20 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-10-08 17:16:14 PDT 
Inline logicalHeightForRowSizing to shave another 2-3% off robohornet's resizecol.html
Comment 1 Eric Seidel (no email) 2012-10-08 17:20:28 PDT 
Created attachment 167654 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-10-08 17:21:06 PDT 
Oh subpixelers: I welcome your thoughts on how we might make this function even simpler. :)
Comment 3 Emil A Eklund 2012-10-08 17:40:50 PDT 
Comment on attachment 167654 [details]
Patch

I like it! We could definitely do better if we only use pixels, then again with the move to 1/64 the cost of translating between layout units and ints is quite low.
Comment 4 WebKit Review Bot 2012-10-08 18:39:16 PDT 
Comment on attachment 167654 [details]
Patch

Clearing flags on attachment: 167654

Committed r130710: <http://trac.webkit.org/changeset/130710>
Comment 5 WebKit Review Bot 2012-10-08 18:39:20 PDT 
All reviewed patches have been landed.  Closing bug.