Bug 98695 - Make exporting symbols on Windows less mysterious
Summary: Make exporting symbols on Windows less mysterious
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Windows 2000
: P2 Normal
Assignee: Roger Fong
Depends on:
Reported: 2012-10-08 15:35 PDT by Simon Fraser (smfr)
Modified: 2013-01-15 23:55 PST (History)
4 users (show)

See Also:

patch (264.42 KB, patch)
2013-01-09 15:55 PST, Roger Fong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-10-08 15:35:57 PDT
After http://trac.webkit.org/changeset/63151, exports from the combined WK1/WK2 dll on windows are controlled by a WebKit2.def file in Source/WebKit2/win/ which is very confusing. This should be cleaned up; I think it would make more sense living in Souce/WebKit or some other directory.
Comment 1 Roger Fong 2012-10-08 15:43:09 PDT
I'm thinking I'll reorganize things when I do VS2010 stuff, which should be in the near future.
Comment 2 Roger Fong 2013-01-09 12:00:11 PST
bfulgham created an webkitexportgenerator project that use a webkit2.def.in file (later moved changed to webkit.def.in and moved to the webkit folder in http://trac.webkit.org/changeset/138759). 

Also, see http://trac.webkit.org/wiki/ExportingSymbols
Comment 3 Roger Fong 2013-01-09 15:55:46 PST
Created attachment 182000 [details]

Changes the name of the definition files so they're easier to find.
Comment 4 Roger Fong 2013-01-09 15:58:38 PST
(In reply to comment #3)
> Created an attachment (id=182000) [details]
> patch
> Changes the name of the definition files so they're easier to find.

VS moved some file orders around in the proj files around to make this patch slightly larger. Wouldn't worry about it though.
Comment 5 Roger Fong 2013-01-09 18:06:12 PST
Comment 6 Jon Lee 2013-01-15 23:55:24 PST
Comment on attachment 182000 [details]

Remove review flag since this has been checked in.