Bug 98686 – editing/pasteboard/data-transfer-item is failing after r130643

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dirk Pranke]

It looks like maybe we just need a new baseline now that kling landed the change in r130588 to change to an ordered collection (maybe the order has changed for the better)?

Ryosuke, can you confirm that the change is okay, or let us know if you think there's still a bug here?

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=editing%2Fpasteboard%2Fdata-transfer-items.html

https://bugs.webkit.org/show_bug.cgi?id=98406

http://trac.webkit.org/changeset/130643

http://trac.webkit.org/changeset/130588

http://webkit.org/b/98547

[Tony Chang]

I think this is fine to rebaseline.  The order of clipboard types isn't defined.  dcheng can confirm.

[Andreas Kling]

Created attachment 167613 [details]
Speculative fix

[Ryosuke Niwa]

(In reply to comment #1)
> I think this is fine to rebaseline.  The order of clipboard types isn't defined.  dcheng can confirm.

I think it needs to preserve the order if it's created by the author script.

[Tony Chang]

(In reply to comment #3)
> (In reply to comment #1)
> > I think this is fine to rebaseline.  The order of clipboard types isn't defined.  dcheng can confirm.
> 
> I think it needs to preserve the order if it's created by the author script.

You're right, I think the intent is that it behaves like a list.

[WebKit Review Bot]

Comment on attachment 167613 [details]
Speculative fix

Clearing flags on attachment: 167613

Committed r130712: <http://trac.webkit.org/changeset/130712>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Tony Chang]

Test result updated in http://trac.webkit.org/changeset/141449 .