Bug 98671 - Upstream some tweaks for overlay play button on Android
Summary: Upstream some tweaks for overlay play button on Android
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 66687
  Show dependency tree / graph
 
Reported: 2012-10-08 11:35 PDT by Min Qin
Modified: 2012-10-08 13:58 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.53 KB, patch)
2012-10-08 11:38 PDT, Min Qin 		no flags Details | Formatted Diff | Diff
Patch (1.76 KB, patch)
2012-10-08 12:02 PDT, Min Qin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Min Qin 2012-10-08 11:35:03 PDT 
Upstream some tweaks for overlay play button on Android
Comment 1 Min Qin 2012-10-08 11:38:50 PDT 
Created attachment 167573 [details]
Patch
Comment 2 Adam Barth 2012-10-08 11:51:59 PDT 
Comment on attachment 167573 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167573&action=review

> Source/WebCore/css/mediaControlsChromiumAndroid.css:93
> +    overflow:hidden;

Looks like you're missing a space after the :
Comment 3 Min Qin 2012-10-08 12:02:15 PDT 
Created attachment 167580 [details]
Patch
Comment 4 Min Qin 2012-10-08 12:03:42 PDT 
Oops. Sorry, fixed, also fixed some other offenders in the same file
(In reply to comment #2)
> (From update of attachment 167573 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167573&action=review
> 
> > Source/WebCore/css/mediaControlsChromiumAndroid.css:93
> > +    overflow:hidden;
> 
> Looks like you're missing a space after the :
Comment 5 Adam Barth 2012-10-08 12:25:08 PDT 
Comment on attachment 167580 [details]
Patch

Thanks!
Comment 6 WebKit Review Bot 2012-10-08 13:58:39 PDT 
Comment on attachment 167580 [details]
Patch

Clearing flags on attachment: 167580

Committed r130683: <http://trac.webkit.org/changeset/130683>
Comment 7 WebKit Review Bot 2012-10-08 13:58:43 PDT 
All reviewed patches have been landed.  Closing bug.