Bug 98661 - Make all of the WebContext sub objects MessageReceivers
Summary: Make all of the WebContext sub objects MessageReceivers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-08 10:24 PDT by Sam Weinig
Modified: 2012-10-10 12:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (50.90 KB, patch)
2012-10-09 19:58 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (50.98 KB, patch)
2012-10-09 20:44 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (53.84 KB, patch)
2012-10-09 22:13 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2012-10-08 10:24:51 PDT 
Make all of the WebContext sub objects MessageReceivers
Comment 1 Sam Weinig 2012-10-09 19:58:40 PDT 
Created attachment 167899 [details]
Patch
Comment 2 Anders Carlsson 2012-10-09 20:05:18 PDT 
Comment on attachment 167899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167899&action=review

> Source/WebKit2/ChangeLog:8
> +
> +        

Extra newline.
Comment 3 WebKit Review Bot 2012-10-09 20:10:26 PDT 
Attachment 167899 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/WebDatabaseManagerProxy.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Gyuyoung Kim 2012-10-09 20:35:32 PDT 
Comment on attachment 167899 [details]
Patch

Attachment 167899 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14223971
Comment 5 Sam Weinig 2012-10-09 20:44:53 PDT 
Created attachment 167907 [details]
Patch
Comment 6 Sam Weinig 2012-10-09 22:13:51 PDT 
Created attachment 167920 [details]
Patch
Comment 7 WebKit Review Bot 2012-10-10 12:06:55 PDT 
Comment on attachment 167920 [details]
Patch

Clearing flags on attachment: 167920

Committed r130939: <http://trac.webkit.org/changeset/130939>
Comment 8 WebKit Review Bot 2012-10-10 12:06:59 PDT 
All reviewed patches have been landed.  Closing bug.