Bug 98648 – DumpRenderTree should have --pixel-tests option again

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Balazs Kelemen]

It turned out that it is useful to have a way to turn on pixel testing from the command line. See bug 95098 for example. I also often feel the luck of it when working with pixel tests. Let's add it back.

[Balazs Kelemen]

Created attachment 167537 [details]
Patch

[Build Bot]

Comment on attachment 167537 [details]
Patch

Attachment 167537 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14201746

[Balazs Kelemen]

Created attachment 167543 [details]
Patch

[Eric Seidel (no email)]

Why is this useful?  Pixel tests require a harness to parse them from the input stream and write out the png files, etc, no?

[Dirk Pranke]

(In reply to comment #4)
> Why is this useful?  Pixel tests require a harness to parse them from the input stream and write out the png files, etc, no?

While that would seem to be true, I have heard the complaint from many people that they miss the flag. I guess maybe they extract the PNGs manually or something?

[Balazs Kelemen]

(In reply to comment #5)
> (In reply to comment #4)
> > Why is this useful?  Pixel tests require a harness to parse them from the input stream and write out the png files, etc, no?
> 
> While that would seem to be true, I have heard the complaint from many people that they miss the flag. I guess maybe they extract the PNGs manually or something?

I often just check whether it is crashing or not or check if the output is an empty image (this is recognizable from the output).

[Balazs Kelemen]

Anyone up to review this?

[Dirk Pranke]

Comment on attachment 167543 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167543&action=review

Sorry, this must've fallen off my radar :(.

> Tools/DumpRenderTree/qt/DumpRenderTreeMain.cpp:69
> +// We only support -v, -p, --pixel-tests, --stdout, --stderr and -, all the others will be

-p doesn't actually work, does it? just --pixel-tests? 

Ideally we'd support -p everywhere as well.

[Balazs Kelemen]

(In reply to comment #8)
> (From update of attachment 167543 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167543&action=review
> 
> Sorry, this must've fallen off my radar :(.
> 
> > Tools/DumpRenderTree/qt/DumpRenderTreeMain.cpp:69
> > +// We only support -v, -p, --pixel-tests, --stdout, --stderr and -, all the others will be
> 
> -p doesn't actually work, does it? just --pixel-tests? 
> 
> Ideally we'd support -p everywhere as well.

Landed in http://trac.webkit.org/changeset/133574.
I added -p to Qt's DRT and WTR, but I didn't do it for other ports.