Bug 98646 - [GTK] Add a setting to enable/disable smooth scrolling to WebKit2 GTK+ API
Summary: [GTK] Add a setting to enable/disable smooth scrolling to WebKit2 GTK+ API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2012-10-08 06:38 PDT by Carlos Garcia Campos
Modified: 2012-10-08 08:06 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.61 KB, patch)
2012-10-08 06:42 PDT, Carlos Garcia Campos 		xan.lopez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-10-08 06:38:07 PDT 
ssia
Comment 1 Carlos Garcia Campos 2012-10-08 06:42:45 PDT 
Created attachment 167534 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-08 06:45:51 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Review Bot 2012-10-08 06:46:11 PDT 
Attachment 167534 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1056:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1058:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1059:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1060:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1061:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h"
Total errors found: 5 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Xan Lopez 2012-10-08 07:07:14 PDT 
Comment on attachment 167534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167534&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:2701
> +    g_object_notify(G_OBJECT(settings), "enable-page-cache");

Copy&paste mistake.
Comment 5 Carlos Garcia Campos 2012-10-08 08:01:32 PDT 
(In reply to comment #4)
> (From update of attachment 167534 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167534&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:2701
> > +    g_object_notify(G_OBJECT(settings), "enable-page-cache");
> 
> Copy&paste mistake.

Ooops
Comment 6 Carlos Garcia Campos 2012-10-08 08:06:01 PDT 
Committed r130642: <http://trac.webkit.org/changeset/130642>