RESOLVED FIXED 98643
[EFL][WK2] Use URL instead of URI in the API 
https://bugs.webkit.org/show_bug.cgi?id=98643
Summary [EFL][WK2] Use URL instead of URI in the API
Chris Dumez
Reported 2012-10-08 05:26:29 PDT
We currently use both URL and URI in the WK2 EFL API. We should switch to using only one of them for consistency (as discussed on the mailing list).
Attachments
Patch (44.83 KB, patch)
2012-10-08 06:00 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-10-08 06:00:39 PDT
Created attachment 167528 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-10-08 06:05:22 PDT
Comment on attachment 167528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167528&action=review > Tools/MiniBrowser/efl/CMakeLists.txt:49 > -ADD_DEFINITIONS(-DTHEME_DIR=\"${THEME_BINARY_DIR}\") > +ADD_DEFINITIONS(-DTHEME_DIR=\"${THEME_BINARY_DIR}\" -DEFL_WK2=1) you want to commit this?
Chris Dumez
Comment 3 2012-10-08 06:09:29 PDT
(In reply to comment #2) > (From update of attachment 167528 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167528&action=review > > > Tools/MiniBrowser/efl/CMakeLists.txt:49 > > -ADD_DEFINITIONS(-DTHEME_DIR=\"${THEME_BINARY_DIR}\") > > +ADD_DEFINITIONS(-DTHEME_DIR=\"${THEME_BINARY_DIR}\" -DEFL_WK2=1) > > you want to commit this? Yes, unless someone has a better idea. url_bar.c is shared by both EWebLauncher and Minibrowser so I need to way to distinguish if I should use WK1 or WK2 API.
WebKit Review Bot
Comment 4 2012-10-08 07:03:52 PDT
Comment on attachment 167528 [details] Patch Clearing flags on attachment: 167528 Committed r130637: <http://trac.webkit.org/changeset/130637>
WebKit Review Bot
Comment 5 2012-10-08 07:03:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.