Bug 98643 - [EFL][WK2] Use URL instead of URI in the API
Summary: [EFL][WK2] Use URL instead of URI in the API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-08 05:26 PDT by Chris Dumez
Modified: 2012-10-08 07:03 PDT (History)
7 users (show)

See Also:

Attachments
Patch (44.83 KB, patch)
2012-10-08 06:00 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-08 05:26:29 PDT 
We currently use both URL and URI in the WK2 EFL API. We should switch to using only one of them for consistency (as discussed on the mailing list).
Comment 1 Chris Dumez 2012-10-08 06:00:39 PDT 
Created attachment 167528 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-10-08 06:05:22 PDT 
Comment on attachment 167528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167528&action=review

> Tools/MiniBrowser/efl/CMakeLists.txt:49
> -ADD_DEFINITIONS(-DTHEME_DIR=\"${THEME_BINARY_DIR}\")
> +ADD_DEFINITIONS(-DTHEME_DIR=\"${THEME_BINARY_DIR}\" -DEFL_WK2=1)

you want to commit this?
Comment 3 Chris Dumez 2012-10-08 06:09:29 PDT 
(In reply to comment #2)
> (From update of attachment 167528 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167528&action=review
> 
> > Tools/MiniBrowser/efl/CMakeLists.txt:49
> > -ADD_DEFINITIONS(-DTHEME_DIR=\"${THEME_BINARY_DIR}\")
> > +ADD_DEFINITIONS(-DTHEME_DIR=\"${THEME_BINARY_DIR}\" -DEFL_WK2=1)
> 
> you want to commit this?

Yes, unless someone has a better idea.

url_bar.c is shared by both EWebLauncher and Minibrowser so I need to way to distinguish if I should use WK1 or WK2 API.
Comment 4 WebKit Review Bot 2012-10-08 07:03:52 PDT 
Comment on attachment 167528 [details]
Patch

Clearing flags on attachment: 167528

Committed r130637: <http://trac.webkit.org/changeset/130637>
Comment 5 WebKit Review Bot 2012-10-08 07:03:57 PDT 
All reviewed patches have been landed.  Closing bug.