Contrary to its name, firstLineStyleSlowCase() actually picks up the cached styles. We should thus rename it to cachedFirstLineStyle() (in keeping with RenderObject::uncachedFirstLineStyle()).
Created attachment 167531 [details] Patch
Comment on attachment 167531 [details] Patch It also fetches the first line style. m_style/style() is where it's cached. I don't think this change makes sense.
(In reply to comment #2) > (From update of attachment 167531 [details]) > It also fetches the first line style. m_style/style() is where it's cached. I don't think this change makes sense. Can you explain what you mean? This is the same as getCachedPseudoStyle() and getUncachedPseudoStyle(). The naming right now doesn't make any sense to me because this isn't the slow case, it's just the default case when your document uses first line styles.
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 167531 [details] [details]) > > It also fetches the first line style. m_style/style() is where it's cached. I don't think this change makes sense. > > Can you explain what you mean? This is the same as getCachedPseudoStyle() and getUncachedPseudoStyle(). The naming right now doesn't make any sense to me because this isn't the slow case, it's just the default case when your document uses first line styles. For reference, I requested this change because we have getUncached and getCached for pseudo styles, but first line has uncachedFirstLineStyle() and firstLineStyle() and firstLineStyleSlowCase of which the last one doesn't have a good name since it doesn't tell you what it's really doing. :)
Comment on attachment 167531 [details] Patch OK.
Comment on attachment 167531 [details] Patch Clearing flags on attachment: 167531 Committed r130694: <http://trac.webkit.org/changeset/130694>
All reviewed patches have been landed. Closing bug.
Thanks Eric and Elliott for the review.