Bug 98610 - [EFL][WK2] Fix unused parameter compile warning.
Summary: [EFL][WK2] Fix unused parameter compile warning.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Kangil Han
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-06 23:51 PDT by Kangil Han
Modified: 2012-10-07 22:20 PDT (History)
6 users (show)

See Also:


Attachments
patch (1.74 KB, patch)
2012-10-06 23:52 PDT, Kangil Han
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2012-10-06 23:51:38 PDT
Fixed unused parameter compile warning by removing initiatingPageRef parameter name.
Comment 1 Kangil Han 2012-10-06 23:52:55 PDT
Created attachment 167470 [details]
patch
Comment 2 Laszlo Gombos 2012-10-07 20:06:48 PDT
Comment on attachment 167470 [details]
patch

r=me.

Should we enable error on warning to find these earlier ?
Comment 3 WebKit Review Bot 2012-10-07 20:40:46 PDT
Comment on attachment 167470 [details]
patch

Clearing flags on attachment: 167470

Committed r130614: <http://trac.webkit.org/changeset/130614>
Comment 4 WebKit Review Bot 2012-10-07 20:40:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Kentaro Hara 2012-10-07 21:46:54 PDT
gyuyoung: BTW, what was the conclusion of the webkit-dev@ discussion about how to handle unused parameters?
Comment 6 Chris Dumez 2012-10-07 21:52:28 PDT
(In reply to comment #5)
> gyuyoung: BTW, what was the conclusion of the webkit-dev@ discussion about how to handle unused parameters?

1. Omit argument name if its purpose is clear without name
2. Comment the argument name otherwise
3. Use UNUSED_PARAM() macro in the #else case if the argument is used only in the #ifdef case.
Comment 7 Gyuyoung Kim 2012-10-07 21:54:55 PDT
(In reply to comment #5)
> gyuyoung: BTW, what was the conclusion of the webkit-dev@ discussion about how to handle unused parameters?

Darin's suggestion was adopted. 

http://lists.webkit.org/pipermail/webkit-dev/2012-October/022369.html
Comment 8 Kentaro Hara 2012-10-07 21:55:29 PDT
Thanks!
Comment 9 Chris Dumez 2012-10-07 21:56:12 PDT
(In reply to comment #7)
> (In reply to comment #5)
> > gyuyoung: BTW, what was the conclusion of the webkit-dev@ discussion about how to handle unused parameters?
> 
> Darin's suggestion was adopted. 
> 
> http://lists.webkit.org/pipermail/webkit-dev/2012-October/022369.html

BTW, it does not seem that the coding style was updated.
Comment 10 Gyuyoung Kim 2012-10-07 22:06:22 PDT
(In reply to comment #9)
> (In reply to comment #7)
> > (In reply to comment #5)
> > > gyuyoung: BTW, what was the conclusion of the webkit-dev@ discussion about how to handle unused parameters?
> > 
> > Darin's suggestion was adopted. 
> > 
> > http://lists.webkit.org/pipermail/webkit-dev/2012-October/022369.html
> 
> BTW, it does not seem that the coding style was updated.

Though Ryosuke asked this if this coding style needs to be added, there is no reply about it. It would be good if someone adds this to coding style guide document. But, the mailing thread is enough for me now.

http://lists.webkit.org/pipermail/webkit-dev/2012-October/022375.html
Comment 11 Gyuyoung Kim 2012-10-07 22:08:51 PDT
Kentaro, do you think this coding style should be added to the webkit style guide ?
Comment 12 Kentaro Hara 2012-10-07 22:15:25 PDT
(In reply to comment #11)
> Kentaro, do you think this coding style should be added to the webkit style guide ?

As far as I understood the discussion, people have reached a consensus on the conclusion. So let's add it to the coding style guide, and just reply to the thread saying "I added it". If someone replied "Don't add it", then let's continue the discussion:)
Comment 13 Gyuyoung Kim 2012-10-07 22:20:36 PDT
(In reply to comment #12)
> (In reply to comment #11)
> > Kentaro, do you think this coding style should be added to the webkit style guide ?
> 
> As far as I understood the discussion, people have reached a consensus on the conclusion. So let's add it to the coding style guide, and just reply to the thread saying "I added it". If someone replied "Don't add it", then let's continue the discussion:)

Do you know how to modify it ? It looks I don't have a permission to modify it. Or, Ryousuke can add this.