Fixed unused parameter compile warning by removing initiatingPageRef parameter name.
Created attachment 167470 [details] patch
Comment on attachment 167470 [details] patch r=me. Should we enable error on warning to find these earlier ?
Comment on attachment 167470 [details] patch Clearing flags on attachment: 167470 Committed r130614: <http://trac.webkit.org/changeset/130614>
All reviewed patches have been landed. Closing bug.
gyuyoung: BTW, what was the conclusion of the webkit-dev@ discussion about how to handle unused parameters?
(In reply to comment #5) > gyuyoung: BTW, what was the conclusion of the webkit-dev@ discussion about how to handle unused parameters? 1. Omit argument name if its purpose is clear without name 2. Comment the argument name otherwise 3. Use UNUSED_PARAM() macro in the #else case if the argument is used only in the #ifdef case.
(In reply to comment #5) > gyuyoung: BTW, what was the conclusion of the webkit-dev@ discussion about how to handle unused parameters? Darin's suggestion was adopted. http://lists.webkit.org/pipermail/webkit-dev/2012-October/022369.html
Thanks!
(In reply to comment #7) > (In reply to comment #5) > > gyuyoung: BTW, what was the conclusion of the webkit-dev@ discussion about how to handle unused parameters? > > Darin's suggestion was adopted. > > http://lists.webkit.org/pipermail/webkit-dev/2012-October/022369.html BTW, it does not seem that the coding style was updated.
(In reply to comment #9) > (In reply to comment #7) > > (In reply to comment #5) > > > gyuyoung: BTW, what was the conclusion of the webkit-dev@ discussion about how to handle unused parameters? > > > > Darin's suggestion was adopted. > > > > http://lists.webkit.org/pipermail/webkit-dev/2012-October/022369.html > > BTW, it does not seem that the coding style was updated. Though Ryosuke asked this if this coding style needs to be added, there is no reply about it. It would be good if someone adds this to coding style guide document. But, the mailing thread is enough for me now. http://lists.webkit.org/pipermail/webkit-dev/2012-October/022375.html
Kentaro, do you think this coding style should be added to the webkit style guide ?
(In reply to comment #11) > Kentaro, do you think this coding style should be added to the webkit style guide ? As far as I understood the discussion, people have reached a consensus on the conclusion. So let's add it to the coding style guide, and just reply to the thread saying "I added it". If someone replied "Don't add it", then let's continue the discussion:)
(In reply to comment #12) > (In reply to comment #11) > > Kentaro, do you think this coding style should be added to the webkit style guide ? > > As far as I understood the discussion, people have reached a consensus on the conclusion. So let's add it to the coding style guide, and just reply to the thread saying "I added it". If someone replied "Don't add it", then let's continue the discussion:) Do you know how to modify it ? It looks I don't have a permission to modify it. Or, Ryousuke can add this.