Bug 98608 - Contiguous array allocation should always be inlined
Summary: Contiguous array allocation should always be inlined
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 97288 98996 99196
Blocks: 99234
  Show dependency tree / graph
 
Reported: 2012-10-06 17:43 PDT by Filip Pizlo
Modified: 2012-10-12 22:46 PDT (History)
7 users (show)

See Also:

Attachments
the patch (38.45 KB, patch)
2012-10-12 14:43 PDT, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-10-06 17:43:55 PDT 
Currently it's only inlined in the baseline JIT, which is unfortunate.
Comment 1 Filip Pizlo 2012-10-12 14:43:59 PDT 
Created attachment 168488 [details]
the patch
Comment 2 Filip Pizlo 2012-10-12 20:56:32 PDT 
Landed in http://trac.webkit.org/changeset/131249
Comment 3 Csaba Osztrogonác 2012-10-12 22:36:56 PDT 
(In reply to comment #2)
> Landed in http://trac.webkit.org/changeset/131249

It broke the 32 bit builds:
/ramdisk/qt-linux-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp: In member function 'void JSC::DFG::SpeculativeJIT::compile(JSC::DFG::Node&)':
/ramdisk/qt-linux-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:3628: error: no matching function for call to 'JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject(JSC::AbstractMacroAssembler<JSC::X86Assembler>::TrustedImmPtr, JSC::DFG::GPRReg&, JSC::DFG::GPRReg&, JSC::DFG::GPRReg&, JSC::AbstractMacroAssembler<JSC::X86Assembler>::JumpList&)'[0m
Comment 4 Csaba Osztrogonác 2012-10-12 22:46:45 PDT 
Fix landed in http://trac.webkit.org/changeset/131251