Bug 98607 - Reduce calls to CGImageSourceCopyPropertiesAtIndex from frameSizeAtIndex
Summary: Reduce calls to CGImageSourceCopyPropertiesAtIndex from frameSizeAtIndex
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-10-06 16:01 PDT by Pratik Solanki
Modified: 2012-10-06 17:10 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.24 KB, patch)
2012-10-06 16:05 PDT, Pratik Solanki
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2012-10-06 16:01:55 PDT
ImageSource::orientationAtIndex() always calls CGImageSourceCopyPropertiesAtIndex. However in cases where the call is made from frameSizeAtIndex() we already have image properties. We can refactor the code to avoid a second call to this function under frameSizeAtIndex()
Comment 1 Pratik Solanki 2012-10-06 16:05:10 PDT
Created attachment 167463 [details]
Patch
Comment 2 Pratik Solanki 2012-10-06 16:06:09 PDT
<rdar://problem/12438025>
Comment 3 Pratik Solanki 2012-10-06 17:10:44 PDT
Committed r130591: <http://trac.webkit.org/changeset/130591>