Bug 98604 - WTFURL: implement URL port removal for HTMLAnchorElement
Summary: WTFURL: implement URL port removal for HTMLAnchorElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-06 14:46 PDT by Benjamin Poulain
Modified: 2012-10-07 15:08 PDT (History)
2 users (show)

See Also:


Attachments
Patch (12.87 KB, patch)
2012-10-06 15:11 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-10-06 14:46:57 PDT
Fix the port reset used by HTMLAnchorElement.
Comment 1 Benjamin Poulain 2012-10-06 15:11:04 PDT
Created attachment 167461 [details]
Patch
Comment 2 Adam Barth 2012-10-07 14:51:01 PDT
Comment on attachment 167461 [details]
Patch

Ok.  I'm slightly worried about the dependency on WTFString.
Comment 3 WebKit Review Bot 2012-10-07 15:01:22 PDT
Comment on attachment 167461 [details]
Patch

Clearing flags on attachment: 167461

Committed r130609: <http://trac.webkit.org/changeset/130609>
Comment 4 WebKit Review Bot 2012-10-07 15:01:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Benjamin Poulain 2012-10-07 15:08:48 PDT
(In reply to comment #2)
> Ok.  I'm slightly worried about the dependency on WTFString.

It is only in ParsedURL, which already depends on WTFString. I have been careful not to push anything in the parser.

I added a dependency on LChar in the parser, but I figured we can easily typedef it for use without WTF.