Bug 98591 - [EFL][DRT] Switch default backing store to single
Summary: [EFL][DRT] Switch default backing store to single
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL: http://lists.webkit.org/pipermail/web...
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-06 02:03 PDT by Ryuan Choi
Modified: 2012-10-09 16:01 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.38 KB, patch)
2012-10-07 18:41 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (2.38 KB, patch)
2012-10-07 22:52 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2012-10-06 02:03:02 PDT 
As discussed in webkit-efl mailing list,

I think that it is more suitable to use ewk_view_single as a default backing store of DRT.


After running pixel-tests in my local,
single has 49 image-only regressions and tiled has 54 regressions.

Patch will be added.
Comment 1 Ryuan Choi 2012-10-07 18:41:17 PDT 
Created attachment 167492 [details]
Patch
Comment 2 Ryuan Choi 2012-10-07 22:52:45 PDT 
Created attachment 167511 [details]
Patch
Comment 3 Eric Seidel (no email) 2012-10-08 11:41:30 PDT 
Comment on attachment 167511 [details]
Patch

rs=me.
Comment 4 WebKit Review Bot 2012-10-08 12:18:31 PDT 
Comment on attachment 167511 [details]
Patch

Clearing flags on attachment: 167511

Committed r130673: <http://trac.webkit.org/changeset/130673>
Comment 5 WebKit Review Bot 2012-10-08 12:18:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Balazs Kelemen 2012-10-09 14:59:53 PDT 
By TBS, do you refer some EFL specific thingy or the TBS support in WebKit? In the second case I don't think it's wise to use another backend for testing that you actually ship.
Comment 7 Ryuan Choi 2012-10-09 16:01:11 PDT 
(In reply to comment #6)
> By TBS, do you refer some EFL specific thingy or the TBS support in WebKit? In the second case I don't think it's wise to use another backend for testing that you actually ship.

This is only Efl specific. WebKit1/Efl has used its own TBS (not in WebCore).

Tizen had used TBS of WebKit1/Efl but moved to WebKit2/Efl.
In case of other Efl applications using WebKit1/Efl such as elm_web and eve,
they have used SBS as a default backing store.

So, I believe that testing SBS is more reasonable.

Thank you.