WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
98587
REGRESSION (
r130570
): fast/writing-mode/vertical-subst-font-vert-no-dflt.html fails on non-Chromium platforms
https://bugs.webkit.org/show_bug.cgi?id=98587
Summary
REGRESSION (r130570): fast/writing-mode/vertical-subst-font-vert-no-dflt.html...
Zan Dobersek
Reported
2012-10-05 23:35:45 PDT
fast/writing-mode/vertical-subst-font-vert-no-dflt.html is failing on non-Chromium platforms since being introduced in
r130570
.
http://trac.webkit.org/changeset/130570
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Fwriting-mode%2Fvertical-subst-font-vert-no-dflt.html
Attachments
GTK actual output
(8.91 KB, image/png)
2012-10-05 23:37 PDT
,
Zan Dobersek
no flags
Details
GTK expected output
(8.84 KB, image/png)
2012-10-05 23:37 PDT
,
Zan Dobersek
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2012-10-05 23:37:21 PDT
Created
attachment 167442
[details]
GTK actual output
Zan Dobersek
Comment 2
2012-10-05 23:37:50 PDT
Created
attachment 167444
[details]
GTK expected output
Zan Dobersek
Comment 3
2012-10-05 23:38:57 PDT
(In reply to
comment #1
)
> Created an attachment (id=167442) [details] > GTK actual output
(In reply to
comment #2
)
> Created an attachment (id=167444) [details] > GTK expected output
To analyze the GTK results, it seems as the actual output is correct while the expected output is not rendered correctly.
Xianzhu Wang
Comment 4
2012-10-06 10:56:34 PDT
(In reply to
comment #3
)
> (In reply to
comment #1
) > > Created an attachment (id=167442) [details] [details] > > GTK actual output > > (In reply to
comment #2
) > > Created an attachment (id=167444) [details] [details] > > GTK expected output > > To analyze the GTK results, it seems as the actual output is correct while the expected output is not rendered correctly.
No. According to Unicode standard, the puctucations in CJK vertical text, the punctuations should be rotated, that is, the glyphs should be substituted with the corresponding vertical forms of them according to the GSUB table in the font.
Xianzhu Wang
Comment 5
2012-10-06 11:00:09 PDT
(In reply to
comment #3
)
> (In reply to
comment #1
) > > Created an attachment (id=167442) [details] [details] > > GTK actual output > > (In reply to
comment #2
) > > Created an attachment (id=167444) [details] [details] > > GTK expected output > > To analyze the GTK results, it seems as the actual output is correct while the expected output is not rendered correctly.
(Sorry for early enter of #4. Please ignore it) No. According to Unicode standard, for the puctucations in CJK vertical text, the glyphs should be substituted with the corresponding vertical forms of them according to the GSUB table in the font. The new layout test is testing this behavior. It's a bug that the glyphs are not properly substituted.
Xianzhu Wang
Comment 6
2012-10-06 11:06:01 PDT
(In reply to
comment #5
)
> (In reply to
comment #3
) > > (In reply to
comment #1
) > > > Created an attachment (id=167442) [details] [details] [details] > > > GTK actual output > > > > (In reply to
comment #2
) > > > Created an attachment (id=167444) [details] [details] [details] > > > GTK expected output > > > > To analyze the GTK results, it seems as the actual output is correct while the expected output is not rendered correctly. > > (Sorry for early enter of #4. Please ignore it) >
(In reply to
comment #5
)
> (In reply to
comment #3
) > > (In reply to
comment #1
) > > > Created an attachment (id=167442) [details] [details] [details] > > > GTK actual output > > > > (In reply to
comment #2
) > > > Created an attachment (id=167444) [details] [details] [details] > > > GTK expected output > > > > To analyze the GTK results, it seems as the actual output is correct while the expected output is not rendered correctly. > > (Sorry for early enter of #4. Please ignore it) > > No. According to Unicode standard, for the puctucations in CJK vertical text, the glyphs should be substituted with the corresponding vertical forms of them according to the GSUB table in the font. The new layout test is testing this behavior. It's a bug that the glyphs are not properly substituted.
Sorry I misunderstood the comment about expected and actual results. #3 is correct. In the expected result the vertical forms are unnecessarily rotated, perhaps because the characters are not treated as CJK characters (which should not be rotated in vertical text).
Csaba Osztrogonác
Comment 7
2012-10-08 08:39:18 PDT
Skipped on Qt by
https://trac.webkit.org/changeset/130628
. Please unskip it with the proper fix.
Xianzhu Wang
Comment 8
2012-10-08 11:47:39 PDT
Checked the GTK output again, and found that this is a more fundamental issue: the GTK port just doesn't do anything for vertical CJK text. It just rotates all CJK glyphs same as other glyphs, so the original forms of the punctuations are rotated "as expected", and the ideographs and vertical forms are also rotated unexpectedly. (
bug 50619
)
Xianzhu Wang
Comment 9
2012-10-08 11:48:35 PDT
(In reply to
comment #7
)
> Skipped on Qt by
https://trac.webkit.org/changeset/130628
. > Please unskip it with the proper fix.
Could you attach the actual and expected images on Qt? Thanks.
Csaba Osztrogonác
Comment 10
2012-10-08 13:49:00 PDT
Qt results:
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r130627%20%2843536%29/fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003-diffs.html
Csaba Osztrogonác
Comment 11
2012-10-08 13:49:56 PDT
Ooops, it was wrong URL. Here is the correct one:
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r130627%20%2843536%29/fast/writing-mode/vertical-subst-font-vert-no-dflt-diffs.html
Xianzhu Wang
Comment 12
2012-10-08 13:53:51 PDT
(In reply to
comment #11
)
> Ooops, it was wrong URL. > > Here is the correct one:
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r130627%20%2843536%29/fast/writing-mode/vertical-subst-font-vert-no-dflt-diffs.html
Thanks for the result. So this is the bug:
https://bugs.webkit.org/show_bug.cgi?id=51584
.
Stephen Chenney
Comment 13
2013-04-09 17:07:18 PDT
Marked LayoutTest bugs, bugs with Chromium IDs, and some others as WontFix. Test failure bugs still are trackable via TestExpectations or disabled unit tests.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug