Bug 98579 – REGRESSION (r128787): Fixed position div causes other elements to not update correctly

• Status: ASSIGNED
• Component: WebCore Misc.

[Kevin M. Dean]

This test link is reduced from a wordpress admin page where it places an admin bar with a position: fixed; on it.

Load the test page. Scroll the Shortcodes list. About 25% down it stops updating, but if you roll your arrow over the content, that triggers and rendering update. Scroll it back to the top and it starts updating normally again.

Removing the position: fixed; from the top div with Web Inspector causes the glitch to not occur.

Likely related to Bug 98578

[Simon Fraser (smfr)]

It pops into compositing layers then stops updating.

[Radar WebKit Bug Importer]

<rdar://problem/12454632>

[Simon Fraser (smfr)]

Created attachment 168848 [details]
Simpler testcase

[Simon Fraser (smfr)]

As you scroll, the positioned children of the overflow div overlap the position:fixed bar, so they become composited (even though they are clipped out, which could be improved).

The issue here is related to the fact that we create a compositing layer for the overflow:hidden, but it is marked as not requiring its own backing store. When scrolling, we repaint this layer's m_repaintRect, but that has been computing local to this layer, even though the layer doesn't paint itself.

[Simon Fraser (smfr)]

Created attachment 168860 [details]
Patch

[Rik Cabanier]

Attachment 168860 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
LayoutTests/compositing/repaint/requires-backing-repaint-expected.png:0:  Set the svn:mime-type property (svn propset svn:mime-type image/png LayoutTests/compositing/repaint/requires-backing-repaint-expected.png).  [image/png] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 168860 [details]
Patch

Attachment 168860 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14392050

New failing tests:
compositing/repaint/requires-backing-repaint.html
platform/chromium/virtual/softwarecompositing/repaint/requires-backing-repaint.html

[Simon Fraser (smfr)]

Created attachment 168981 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 168981 [details]
Patch

http://trac.webkit.org/changeset/131479

Keeping the bug open because there's still an issue with the scrollbar layers not showing up right away.

[Eric Seidel (no email)]

Comment on attachment 168981 [details]
Patch

Cleared Beth Dakin's review+ from obsolete attachment 168981 [details] so that this bug does not appear in http://webkit.org/pending-commit.