Bug 98574 – Some GraphicsLayer cleanup to separate the concepts of using a tile cache, and being the main tile cache layer

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Some GraphicsLayer cleanup to separate the concepts of using a tile cache, and being the main tile cache layer

[Simon Fraser (smfr)]

Created attachment 167414 [details]
Patch

[Build Bot]

Comment on attachment 167414 [details]
Patch

Attachment 167414 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14178648

[Simon Fraser (smfr)]

Created attachment 167429 [details]
Patch

[Build Bot]

Comment on attachment 167429 [details]
Patch

Attachment 167429 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14179685

[Dean Jackson]

7>..\FullscreenVideoController.cpp(250) : error C2259: 'FullscreenVideoController::LayerClient' : cannot instantiate abstract class
7>        due to following members:
7>        'bool WebCore::PlatformCALayerClient::platformCALayerShowRepaintCounter(WebCore::PlatformCALayer *) const' : is abstract
7>        c:\cygwin\home\buildbot\webkit\webkitbuild\debug\include\webcore\PlatformCALayerClient.h(55) : see declaration of 'WebCore::PlatformCALayerClient::platformCALayerShowRepaintCounter'

[Simon Fraser (smfr)]

Boo.

[Dean Jackson]

Comment on attachment 167429 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167429&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:341
> +void GraphicsLayer::debugBorderInfo(Color& color, float& width) const

In a recent review from Darin, he said "We reserve the word 'get' for functions that have no return value and use out arguments instead". When I was seeing this used in action below, it wasn't clear the function was doing anything since you don't get return values. Maybe it should be getDebugBorderInfo?

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:373
> +    Color borderColor;
> +    float width = 0;
> +    debugBorderInfo(borderColor, width);
> +    setDebugBorder(borderColor, width);

Here's the place I was talking about above.

> Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:99
> -    if (owner()->owner()->platformCALayerShowRepaintCounter()) {
> +    if (owner()->owner()->platformCALayerShowRepaintCounter(owner())) {

wow.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/130676