WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
98563
Form controls should always be horizontal
https://bugs.webkit.org/show_bug.cgi?id=98563
Summary
Form controls should always be horizontal
Tony Chang
Reported
2012-10-05 15:31:38 PDT
WebKit doesn't support vertical controls yet. It's a regression that we even try now. The intent of the CSS in html.css is to force controls to horizontal-tb, but this must have been lost when switching from -webkit-block-flow to -webkit-writing-mode.
Attachments
Patch
(57.20 KB, patch)
2012-10-05 15:40 PDT
,
Tony Chang
no flags
Details
Formatted Diff
Diff
Patch
(58.73 KB, patch)
2012-10-05 15:43 PDT
,
Tony Chang
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Tony Chang
Comment 1
2012-10-05 15:36:14 PDT
14:44 < tony^work> dhyatt: The user agent stylesheet (html.css) has some CSS that sets -webkit-block-flow: tb on form elements. Should I just delete that code? 14:45 < dhyatt> oh actually it should turn into writing-mode 14:45 < dhyatt> patch rather than delete 14:45 < dhyatt> writing-mode should reset for form controls 14:45 < tony^work> The writing mode spec seems to suggest we should be able to support vertical controls 14:45 < dhyatt> just as many other props do 14:45 < dhyatt> yes, someday we might support vertical controls 14:46 < dhyatt> but until platforms have that support, we can't just mis-render
Tony Chang
Comment 2
2012-10-05 15:40:36 PDT
Created
attachment 167398
[details]
Patch
Tony Chang
Comment 3
2012-10-05 15:43:15 PDT
Created
attachment 167401
[details]
Patch
Tony Chang
Comment 4
2012-10-05 15:43:37 PDT
Comment on
attachment 167401
[details]
Patch I forgot to add the new -expected.html files.
WebKit Review Bot
Comment 5
2012-10-05 16:57:08 PDT
Comment on
attachment 167401
[details]
Patch Clearing flags on attachment: 167401 Committed
r130569
: <
http://trac.webkit.org/changeset/130569
>
WebKit Review Bot
Comment 6
2012-10-05 16:57:13 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug