Bug 98558 – Re-enable WebFrameTest.DivScrollIntoEditableTest

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[WebKit Review Bot]

Re-enable WebFrameTest.DivScrollIntoEditableTest
Requested by abarth on #webkit.

[Xianzhu Wang]

Created attachment 185153 [details]
Patch

[Xianzhu Wang]

Created attachment 185154 [details]
Patch (comments updated)

[Xianzhu Wang]

The original comment above the function read "This test depends on code that is compiled conditionally." I wonder what the macro is and what the original problem was.

[Adam Barth]

I don't remember, but re-enabling it is likely to just cause the same failures.  Perhaps we should run a try job to try to figure out what the issue was?

[Xianzhu Wang]

I modified the test at several places to make it pass in my environment locally (chromium-linux). Will cr-linux ews run webkit_unit_tests?

[Adam Barth]

> Will cr-linux ews run webkit_unit_tests?

Yes, but only on linux.  Do you know if it passes on cr-android as well?

[Xianzhu Wang]

Tried the test with the patch on chromium-android. It passed.

The tested code is all in WebViewImpl::scrollFocusedNodeIntoRect(). The conditionally compiled code seems not to cause problem now, given that the test has been modified to be consistent with the current code.

[Adam Barth]

Comment on attachment 185154 [details]
Patch (comments updated)

OK.  Let's land this and see what happens!

[WebKit Review Bot]

Comment on attachment 185154 [details]
Patch (comments updated)

Clearing flags on attachment: 185154

Committed r141064: <http://trac.webkit.org/changeset/141064>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by bug 108166

[Keishi Hattori]

Test seems to be failing on WinXP so I am rolling the patch out.

http://chromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20XP/builds/2419/steps/webkit_unit_tests/logs/DivScrollIntoEditableTest

WebFrameTest.DivScrollIntoEditableTest: 
tests\WebFrameTest.cpp(974): error: Value of: webView->mainFrame()->scrollOffset().width
Actual: 494
Expected: hScroll
Which is: 495

[Build Bot]

Comment on attachment 185154 [details]
Patch (comments updated)

Attachment 185154 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16151142

New failing tests:
http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html

[Xianzhu Wang]

Created attachment 185256 [details]
Use EXPECT_NEAR to tolerate inaccuracy

[Xianzhu Wang]

Comment on attachment 185256 [details]
Use EXPECT_NEAR to tolerate inaccuracy

Just found that though the changed test passes, it misses a case to test. Will update the patch soon.

[Xianzhu Wang]

Created attachment 185264 [details]
Patch

[Xianzhu Wang]

The test will be rewritten in bug 107599. We are obsoleting webkit scaling so we don't need the original test any more.