Bug 98553 - Remove "orphaned units" quirk
Summary: Remove "orphaned units" quirk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tab Atkins
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-05 13:45 PDT by Tab Atkins
Modified: 2012-10-08 12:00 PDT (History)
15 users (show)

See Also:

Attachments
Patch (6.07 KB, patch)
2012-10-05 14:19 PDT, Tab Atkins 		no flags Details | Formatted Diff | Diff
Patch (68.56 KB, patch)
2012-10-05 18:59 PDT, Tab Atkins 		no flags Details | Formatted Diff | Diff
Patch (69.26 KB, patch)
2012-10-05 19:39 PDT, Tab Atkins 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tab Atkins 2012-10-05 13:45:12 PDT 
The "orphaned units" quirk allows things like "width: 20 px;" (note the space between number and unit).

This is justified as matching WinIE behavior, but neither FF nor Opera do it, and their devs don't seem to be aware of any bug reports about it.  

It also wasn't important enough to justify being put into Simon Pieters' Quirks Mode spec <http://dvcs.w3.org/hg/quirks-mode/raw-file/tip/Overview.html>, which was based on surveying browsers and seeing what quirks were needed for web compat.

So, I'm removing it.
Comment 1 Tab Atkins 2012-10-05 14:19:58 PDT 
Created attachment 167379 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-05 15:19:20 PDT 
Comment on attachment 167379 [details]
Patch

Attachment 167379 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14169925

New failing tests:
WebFrameTest.DivScrollIntoEditableTest
touchadjustment/zoom-fatfinger.html
fast/css/quirk-orphaned-units.html
Comment 3 Build Bot 2012-10-05 18:01:36 PDT 
Comment on attachment 167379 [details]
Patch

Attachment 167379 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14082046

New failing tests:
mathml/presentation/fractions.xhtml
fast/css/quirk-orphaned-units.html
Comment 4 Tab Atkins 2012-10-05 18:59:14 PDT 
Created attachment 167434 [details]
Patch
Comment 5 Tab Atkins 2012-10-05 19:00:26 PDT 
(In reply to comment #4)
> Created an attachment (id=167434) [details]
> Patch

I can't tell how the WebFrameTest or mathml tests were related to this quirk, so I'll let the bots cycle around again and see if the failure is reproducible.  I've fixed the other two.
Comment 6 Build Bot 2012-10-05 19:37:35 PDT 
Comment on attachment 167434 [details]
Patch

Attachment 167434 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14182610

New failing tests:
mathml/presentation/fractions.xhtml
Comment 7 Tab Atkins 2012-10-05 19:39:58 PDT 
Created attachment 167436 [details]
Patch
Comment 8 Tab Atkins 2012-10-05 19:40:42 PDT 
(In reply to comment #7)
> Created an attachment (id=167436) [details]
> Patch

All right, found the bug in the mathml test that was depending on this quirk accidentally.  Should hopefully go full-green now.
Comment 9 Eric Seidel (no email) 2012-10-08 11:52:42 PDT 
Comment on attachment 167436 [details]
Patch

SGTM.
Comment 10 WebKit Review Bot 2012-10-08 12:00:33 PDT 
Comment on attachment 167436 [details]
Patch

Clearing flags on attachment: 167436

Committed r130668: <http://trac.webkit.org/changeset/130668>
Comment 11 WebKit Review Bot 2012-10-08 12:00:39 PDT 
All reviewed patches have been landed.  Closing bug.