Bug 98550 - Remove needless virtual calls and inline RenderStyle::logical* to make table layout faster
Summary: Remove needless virtual calls and inline RenderStyle::logical* to make table ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 98798
  Show dependency treegraph
 
Reported: 2012-10-05 13:21 PDT by Eric Seidel (no email)
Modified: 2012-10-09 11:20 PDT (History)
5 users (show)

See Also:


Attachments
Patch (5.07 KB, patch)
2012-10-05 13:24 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-10-05 13:21:38 PDT
Remove needless virtual calls and inline RenderStyle::logical* to make table layout faster
Comment 1 Eric Seidel (no email) 2012-10-05 13:24:29 PDT
Created attachment 167373 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-10-05 14:15:17 PDT
Comment on attachment 167373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167373&action=review

> Source/WebCore/rendering/AutoTableLayout.cpp:52
> +    for (RenderObject* child = m_table->children()->firstChild(); child; child = child->nextSibling()) {

For the uninitiated: firstChild() calls virtualChildren()->firstChild(), and is defined on RenderObject.  The pointer in question already has a non-virtual children() method which is faster. :)
Comment 3 Andreas Kling 2012-10-05 14:47:45 PDT
Comment on attachment 167373 [details]
Patch

Nifty! r=me
Comment 4 WebKit Review Bot 2012-10-05 15:08:58 PDT
Comment on attachment 167373 [details]
Patch

Clearing flags on attachment: 167373

Committed r130560: <http://trac.webkit.org/changeset/130560>
Comment 5 WebKit Review Bot 2012-10-05 15:09:02 PDT
All reviewed patches have been landed.  Closing bug.