Bug 98524 - [WK2][WTR] WebKitTestRunner needs testRunner.setSerializeHTTPLoads
Summary: [WK2][WTR] WebKitTestRunner needs testRunner.setSerializeHTTPLoads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sudarsana Nagineni (babu)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-05 08:47 PDT by Sudarsana Nagineni (babu)
Modified: 2012-10-05 16:42 PDT (History)
4 users (show)

See Also:

Attachments
Patch (9.04 KB, patch)
2012-10-05 09:08 PDT, Sudarsana Nagineni (babu) 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Patch (9.05 KB, patch)
2012-10-05 09:51 PDT, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
Patch (8.70 KB, patch)
2012-10-05 14:04 PDT, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2012-10-05 08:47:50 PDT 
Add support for testrunner.setSerializeHTTPLoads.
Comment 1 Sudarsana Nagineni (babu) 2012-10-05 09:08:07 PDT 
Created attachment 167334 [details]
Patch
Comment 2 Build Bot 2012-10-05 09:12:04 PDT 
Comment on attachment 167334 [details]
Patch

Attachment 167334 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14182440
Comment 3 Build Bot 2012-10-05 09:33:26 PDT 
Comment on attachment 167334 [details]
Patch

Attachment 167334 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14181425
Comment 4 Sudarsana Nagineni (babu) 2012-10-05 09:51:37 PDT 
Created attachment 167340 [details]
Patch

Fixed build issues.
Comment 5 Alexey Proskuryakov 2012-10-05 10:37:04 PDT 
Implementation looks 100% right to me. It's confusing that it only fixes two tests. Do you know what's wrong with the other two?

I have no objection against landing the patch, but an implementation that doesn't make tests pass is less useful than it could be.
Comment 6 Sudarsana Nagineni (babu) 2012-10-05 14:01:53 PDT 
Thanks for reviewing, Alexey.

My mistake - I think earlier I tested with some experimental changes locally. Now, I re-tested this and all the corresponding tests are passing. I'm going to update the patch.
Comment 7 Sudarsana Nagineni (babu) 2012-10-05 14:04:30 PDT 
Created attachment 167378 [details]
Patch
Comment 8 WebKit Review Bot 2012-10-05 16:42:35 PDT 
Comment on attachment 167378 [details]
Patch

Clearing flags on attachment: 167378

Committed r130568: <http://trac.webkit.org/changeset/130568>
Comment 9 WebKit Review Bot 2012-10-05 16:42:38 PDT 
All reviewed patches have been landed.  Closing bug.