Bug 98523 – [Mac] REGRESSION (r130411-r130414): fast/images/repaint-subrect-grid.html failing on Apple MountainLion Debug WK2 (Tests)

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jer Noble]

fast/images/repaint-subrect-grid.html started failing on Apple MountainLion Debug WK2 (Tests) between r130412 and r130414 (inclusive).

http://trac.webkit.org/log/trunk?rev=130414&stop_rev=130412&limit=4

http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r130411%20(1862)/results.html passed
http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r130414%20(1863)/results.html failed

Looks like the Mac port needs to add testRunner.displayInvalidatedRegion() support.

[Jer Noble]

Checked in expected failure in r130510.

[Simon Fraser (smfr)]

We should remove testRunner.displayInvalidatedRegion(), and eventually display() too.

Created attachment 172059 [details]
Patch

Created attachment 172060 [details]
Patch

Sorry for the extra patch. I'd left some unnecessary lines in the test that are
no longer needed now that text-based-repaint.js is driving things.

[Simon Fraser (smfr)]

Comment on attachment 172060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172060&action=review

> LayoutTests/ChangeLog:9
> +        The repaint-subrect-grid.html layout test is now text-based and
> +        doesn't use testRunner.displayInvalidatedRegion().

Is this the only test that used displayInvalidatedRegion()?

[WebKit Review Bot]

Comment on attachment 172060 [details]
Patch

Clearing flags on attachment: 172060

Committed r133322: <http://trac.webkit.org/changeset/133322>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #6)
> (From update of attachment 172060 [details])
> Clearing flags on attachment: 172060
> 
> Committed r133322: <http://trac.webkit.org/changeset/133322>

The unskipped test fails on Qt:
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r133416%20%2844686%29/fast/images/repaint-subrect-grid-pretty-diff.html

Could you check if this result is correct or not? I don't know anything about how this test works and what this coordinates mean.