Bug 98522 – No autorelease pool in place, causing buildup of autoreleased objects.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jer Noble]

No autorelease pool in place, causing buildup of autoreleased objects.

[Jer Noble]

Created attachment 167332 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 167332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167332&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=98522

If there is a Radar bug tracking this, please post its number to Bugzilla and to ChangeLog.

> Source/WebCore/platform/cf/RunLoopTimerCF.cpp:49
> +    AutodrainedPool pool;

This won't break Windows build, will it? With a cursory look, I couldn't find a no-op implementation of this class that Windows could be using.

[Alexey Proskuryakov]

My mistake - I was looking at a wrong AutodrainedPool.h.

[Jer Noble]

(In reply to comment #2)
> (From update of attachment 167332 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167332&action=review
> 
> > Source/WebCore/ChangeLog:4
> > +        https://bugs.webkit.org/show_bug.cgi?id=98522
> 
> If there is a Radar bug tracking this, please post its number to Bugzilla and to ChangeLog.

Sure thing.

> > Source/WebCore/platform/cf/RunLoopTimerCF.cpp:49
> > +    AutodrainedPool pool;
> 
> This won't break Windows build, will it? With a cursory look, I couldn't find a no-op implementation of this class that Windows could be using.

Yep, as I think you discovered in comment #3, there's a no-op implementation for non-ObjC CF-ports.

[Jer Noble]

<rdar://problem/11647950>

[Jer Noble]

Committed r130534: <http://trac.webkit.org/changeset/130534>