98513 – SVG classes cause layering violations in platform Font code

Bug 98513 - SVG classes cause layering violations in platform Font code

Summary: SVG classes cause layering violations in platform Font code

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Platform (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Stephen Chenney

URL:
Keywords:

Depends on:
Blocks:

Reported:	2012-10-05 06:33 PDT by Stephen Chenney
Modified:	2012-11-02 15:59 PDT (History)
CC List:	7 users (show)

See Also:

Attachments
Patch (5.73 KB, patch) 2012-11-01 15:07 PDT, Stephen Chenney	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Stephen Chenney 2012-10-05 06:33:57 PDT

The WebCore::FontFallbackList header refers to SVG classes as friends. This is a layering violation and can be fixed by making the APIs public in some way.

Comment 1 Stephen Chenney 2012-11-01 15:07:29 PDT

Created attachment 171942 [details]
Patch

Comment 2 Eric Seidel (no email) 2012-11-01 15:12:05 PDT

Comment on attachment 171942 [details]
Patch

Much nicer.

Comment 3 Stephen Chenney 2012-11-01 18:37:18 PDT

Test failures might be real. I'll have to look at it.

Comment 4 Stephen Chenney 2012-11-02 06:01:31 PDT

Comment on attachment 171942 [details]
Patch

Let's try again.

Comment 5 WebKit Review Bot 2012-11-02 06:34:20 PDT

Comment on attachment 171942 [details]
Patch

Clearing flags on attachment: 171942

Committed r133290: <http://trac.webkit.org/changeset/133290>

Comment 6 WebKit Review Bot 2012-11-02 06:34:24 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 Darin Adler 2012-11-02 15:59:25 PDT

Comment on attachment 171942 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171942&action=review

> Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:191
> +    // Save data fromt he font fallback list because we may modify it later. Do this before the

Typo here, "fromt he"