Bug 98483 – [EFL] Use Evas function instead of memcpy

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Jaehun Lim]

Evas supports evas_object_image_data_copy_set() to copy image data.
Change memcpy() with evas_object_image_data_copy_set().

[Jaehun Lim]

Created attachment 167247 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 167247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167247&action=review

> Source/WebKit/efl/ChangeLog:10
> +

Please mention to change variable name.

[Ryuan Choi]

Comment on attachment 167247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167247&action=review

> Source/WebKit/efl/ewk/ewk_util.cpp:39
> +    int width, height, stride;

Let's move this to 66,67,68 line.

> Source/WebKit/efl/ewk/ewk_util.cpp:41
> +    void* data;

Ditto.

> Source/WebKit/efl/ewk/ewk_util.cpp:94
> +        ERR("could not get source data.");
> +        return 0;

Don't you need to delete image?

[Jaehun Lim]

Created attachment 167944 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 167944 [details]
Patch

Looks fine.

[Jaehun Lim]

(In reply to comment #3)
> (From update of attachment 167247 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167247&action=review
> 
> > Source/WebKit/efl/ewk/ewk_util.cpp:39
> > +    int width, height, stride;
> 
> Let's move this to 66,67,68 line.
Done
> 
> > Source/WebKit/efl/ewk/ewk_util.cpp:41
> > +    void* data;
> 
> Ditto.
Done
> 
> > Source/WebKit/efl/ewk/ewk_util.cpp:94
> > +        ERR("could not get source data.");
> > +        return 0;
> 
> Don't you need to delete image?
I moved these lines before "image" was created.

[WebKit Review Bot]

Comment on attachment 167944 [details]
Patch

Clearing flags on attachment: 167944

Committed r130875: <http://trac.webkit.org/changeset/130875>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.