Bug 98482 - [EFL][WK2] ewk_web_error_free is not a public API
Summary: [EFL][WK2] ewk_web_error_free is not a public API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-04 22:01 PDT by Ryuan Choi
Modified: 2012-10-04 23:55 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.05 KB, patch)
2012-10-04 22:29 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (4.71 KB, patch)
2012-10-04 22:45 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (4.71 KB, patch)
2012-10-04 22:49 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2012-10-04 22:01:42 PDT 
Ewk_Web_Error is just passed to application as a callback and it is released internally.

So, we don't need to expose this as public API.
Comment 1 Chris Dumez 2012-10-04 22:25:22 PDT 
Agreed. Thanks.
Comment 2 Ryuan Choi 2012-10-04 22:29:10 PDT 
Created attachment 167249 [details]
Patch
Comment 3 Chris Dumez 2012-10-04 22:34:34 PDT 
Comment on attachment 167249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167249&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_web_error.h:-55
> - * Frees the given object.

This doc should probably be moved to the cpp file with a @internal tag.
Comment 4 Ryuan Choi 2012-10-04 22:45:14 PDT 
Created attachment 167253 [details]
Patch
Comment 5 Ryuan Choi 2012-10-04 22:46:02 PDT 
(In reply to comment #3)
> (From update of attachment 167249 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167249&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_web_error.h:-55
> > - * Frees the given object.
> 
> This doc should probably be moved to the cpp file with a @internal tag.

OK, moved.
Comment 6 Chris Dumez 2012-10-04 22:47:49 PDT 
Comment on attachment 167253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167253&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_web_error.cpp:72
> + * Frees the give object.

"given"
Comment 7 Ryuan Choi 2012-10-04 22:49:09 PDT 
Created attachment 167254 [details]
Patch
Comment 8 Ryuan Choi 2012-10-04 22:49:55 PDT 
(In reply to comment #6)
> (From update of attachment 167253 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167253&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_web_error.cpp:72
> > + * Frees the give object.
> 
> "given"

mistake. fixed.

Thank you.
Comment 9 Chris Dumez 2012-10-04 22:54:09 PDT 
Comment on attachment 167254 [details]
Patch

LGTM. Thanks.
Comment 10 WebKit Review Bot 2012-10-04 23:55:13 PDT 
Comment on attachment 167254 [details]
Patch

Clearing flags on attachment: 167254

Committed r130470: <http://trac.webkit.org/changeset/130470>
Comment 11 WebKit Review Bot 2012-10-04 23:55:18 PDT 
All reviewed patches have been landed.  Closing bug.