Bug 98479 - Add appearance tests for input[type=date] with multiple fields
Summary: Add appearance tests for input[type=date] with multiple fields
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 98226
  Show dependency treegraph
 
Reported: 2012-10-04 21:47 PDT by Kent Tamura
Modified: 2012-10-05 00:58 PDT (History)
3 users (show)

See Also:


Attachments
Patch (101.20 KB, patch)
2012-10-05 00:24 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff
Patch 2 (103.89 KB, patch)
2012-10-05 00:52 PDT, Kent Tamura
haraken: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-10-04 21:47:59 PDT
Add appearance tests for input[type=date] with multiple fields
Comment 1 Kent Tamura 2012-10-05 00:24:18 PDT
Created attachment 167268 [details]
Patch
Comment 2 Yuta Kitamura 2012-10-05 00:33:15 PDT
Comment on attachment 167268 [details]
Patch

Looks fine.
Comment 3 Kentaro Hara 2012-10-05 00:33:41 PDT
Comment on attachment 167268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167268&action=review

> LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html:25
> +<script>

Nit: (Although I don't know the convention of forms tests,) it looks a bit strange to put <script> after </body>.

> LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html:26
> +if (window.testRunner) {

Nit: {} is not needed.

> LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:16
> +<script>

Ditto.

> LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:17
> +if (window.testRunner) {

Ditto.

> LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html:11
> +<script>

Ditto.

> LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html:12
> +if (window.testRunner) {

Ditto.
Comment 4 Yuta Kitamura 2012-10-05 00:38:42 PDT
Comment on attachment 167268 [details]
Patch

Hm, I agree with haraken. Sounds like these points need to be fixed.
Comment 5 Kent Tamura 2012-10-05 00:52:23 PDT
Created attachment 167272 [details]
Patch 2

Fix scripts
Comment 6 Kent Tamura 2012-10-05 00:58:30 PDT
Committed r130480: <http://trac.webkit.org/changeset/130480>