Bug 98478 - Fix font for date/time input types.
Summary: Fix font for date/time input types.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 98226
  Show dependency tree / graph
 
Reported: 2012-10-04 21:46 PDT by Kent Tamura
Modified: 2012-10-04 23:24 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.47 KB, patch)
2012-10-04 22:01 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch 2 (2.60 KB, patch)
2012-10-04 22:05 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-10-04 21:46:46 PDT 
* input[type=date] should use monospace font
* input[type=datetime/datetime-local/time/week/month] should not use monospace font if the type is disabled.
Comment 1 Kent Tamura 2012-10-04 22:01:27 PDT 
Created attachment 167245 [details]
Patch
Comment 2 Kent Tamura 2012-10-04 22:05:52 PDT 
Created attachment 167246 [details]
Patch 2

Update ChangeLog
Comment 3 Kentaro Hara 2012-10-04 22:07:41 PDT 
Comment on attachment 167246 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=167246&action=review

> Source/WebCore/ChangeLog:17
> +        The input[type=date] change is covered by
> +        fast/forms/date/calendar-picker-appearance.html,
> +        platform/chromium/fast/forms/date/date-suggestion-picker-appearance*.html

Why isn't there any change in these test results although you're changing fonts in this patch? Such a minor change is not detected?
Comment 4 Kent Tamura 2012-10-04 22:10:02 PDT 
Comment on attachment 167246 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=167246&action=review

>> Source/WebCore/ChangeLog:17
>> +        platform/chromium/fast/forms/date/date-suggestion-picker-appearance*.html
> 
> Why isn't there any change in these test results although you're changing fonts in this patch? Such a minor change is not detected?

Fortunately these tests are suppressed in TestExpectations for now because they need rebaseline by prior changes.
Comment 5 Kentaro Hara 2012-10-04 22:10:49 PDT 
Comment on attachment 167246 [details]
Patch 2

OK. Please just confirm the appearance manually.
Comment 6 WebKit Review Bot 2012-10-04 23:24:48 PDT 
Comment on attachment 167246 [details]
Patch 2

Clearing flags on attachment: 167246

Committed r130467: <http://trac.webkit.org/changeset/130467>
Comment 7 WebKit Review Bot 2012-10-04 23:24:51 PDT 
All reviewed patches have been landed.  Closing bug.