Bug 98476 – [Chromium] Crash on SpellChecker::didCheck()

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Hajime Morrita]

This upstreams http://code.google.com/p/chromium/issues/detail?id=154231.

[Alexey Proskuryakov]

Could you please all relevant detail here?

[Hajime Morrita]

(In reply to comment #1)
> Could you please all relevant detail here?
Oops. I'm sorry for the lack of the detail.
This path is hit only when asynchronous spellchecking is enabled.

Here is reported stack trace:

0x627c8bcc	 [chrome.dll]	 - spellchecker.cpp:209]	WebCore::SpellChecker::didCheck(int,WTF::Vector<WebCore::TextCheckingResult,0> const &)
0x62061345	 [chrome.dll]	 - threadspecific.h:253]	WTF::ThreadSpecific<WebCore::ThreadGlobalData>::operator WebCore::ThreadGlobalData *()
0x62068a10	 [chrome.dll]	 - threadglobaldata.h:113]	WebCore::threadGlobalData()
0x627c85d1	 [chrome.dll]	 - spellchecker.cpp:88]	WebCore::SpellCheckRequest::didCancel()
0x627c8991	 [chrome.dll]	 - spellchecker.cpp:182]	WebCore::SpellChecker::invokeRequest(WTF::PassRefPtr<WebCore::SpellCheckRequest>)
0x627c87ca	 [chrome.dll]	 - spellchecker.cpp:135]	WebCore::SpellChecker::timerFiredToProcessQueuedRequest(WebCore::Timer<WebCore::SpellChecker> *)
0x6212fac4	 [chrome.dll]	 - timer.h:100]	WebCore::Timer<WebCore::RevalidateStyleAttributeTask>::fired()
0x6212f7bc	 [chrome.dll]	 - threadtimers.cpp:115]	WebCore::ThreadTimers::sharedTimerFiredInternal()
0x62061345	 [chrome.dll]	 - threadspecific.h:253]	WTF::ThreadSpecific<WebCore::ThreadGlobalData>::operator WebCore::ThreadGlobalData *()
0x6212f66a	 [chrome.dll]	 - threadtimers.cpp:93]	WebCore::ThreadTimers::sharedTimerFired()
0x61fa690d	 [chrome.dll]	 - timer.cc:181]	base::Timer::RunScheduledTask()
0x61fa6876	 [chrome.dll]	 - timer.cc:46]	base::BaseTimerTaskInternal::Run()
0x61f877d3	 [chrome.dll]	 - message_loop.cc:470]	MessageLoop::RunTask(base::PendingTask const &)
0x61f870a0	 [chrome.dll]	 - message_loop.cc:661]	MessageLoop::DoWork()
0x61f87d86	 [chrome.dll]	 - message_pump_default.cc:28]	base::MessagePumpDefault::Run(base::MessagePump::Delegate *)
0x61f86d6b	 [chrome.dll]	 - message_loop.cc:427]	MessageLoop::RunInternal()
0x61f86cc3	 [chrome.dll]	 - run_loop.cc:45]	base::RunLoop::Run()
0x61f8d67d	 [chrome.dll]	 - message_loop.cc:307]	MessageLoop::Run()

[Hajime Morrita]

Created attachment 167975 [details]
Patch

[Kent Tamura]

Comment on attachment 167975 [details]
Patch

Looks ok

[WebKit Review Bot]

Comment on attachment 167975 [details]
Patch

Clearing flags on attachment: 167975

Committed r130988: <http://trac.webkit.org/changeset/130988>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.