Bug 98473 - SVGAttributeHashTranslator does not need to copy QualifiedName in the common case
Summary: SVGAttributeHashTranslator does not need to copy QualifiedName in the common ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 98467
  Show dependency tree / graph
 
Reported: 2012-10-04 18:51 PDT by Eric Seidel (no email)
Modified: 2012-10-05 17:14 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.80 KB, patch)
2012-10-04 18:52 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch (1.99 KB, patch)
2012-10-04 18:56 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-10-04 18:51:53 PDT 
SVGAttributeHashTranslator does not need to copy QualifiedName in the common case
Comment 1 Eric Seidel (no email) 2012-10-04 18:52:07 PDT 
Created attachment 167220 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-10-04 18:52:44 PDT 
This makes SVG animation (and anything that changes SVG attributes) much slower than necessary.
Comment 3 Eric Seidel (no email) 2012-10-04 18:53:36 PDT 
I found this while working on another bug.  I sampled my test case and found this code to be super-hot.  This patch made the most of the samples in this area go away. :)
Comment 4 Eric Seidel (no email) 2012-10-04 18:56:13 PDT 
Created attachment 167222 [details]
Patch
Comment 5 WebKit Review Bot 2012-10-04 21:22:22 PDT 
Comment on attachment 167222 [details]
Patch

Clearing flags on attachment: 167222

Committed r130456: <http://trac.webkit.org/changeset/130456>
Comment 6 WebKit Review Bot 2012-10-04 21:22:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Darin Adler 2012-10-05 17:14:52 PDT 
Oh my god! Good one.