98469 – [Refactoring] Some classes in StyleResolver.cpp/h could have its own file.

Bug 98469 - [Refactoring] Some classes in StyleResolver.cpp/h could have its own file.

Summary: [Refactoring] Some classes in StyleResolver.cpp/h could have its own file.

Attachments
Patch (56.41 KB, patch) 2012-10-04 19:23 PDT, Hajime Morrita	no flags	Details \| Formatted Diff \| Diff
Patch (65.69 KB, patch) 2012-10-04 19:56 PDT, Hajime Morrita	no flags	Details \| Formatted Diff \| Diff
Patch (65.69 KB, patch) 2012-10-04 21:17 PDT, Hajime Morrita	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Hajime Morrita 2012-10-04 17:38:31 PDT

This spinned out from Bug 98244.
RuleSet, RuleData, RuleFeature and Features can own its own file.

Comment 1 Hajime Morrita 2012-10-04 19:23:05 PDT

Created attachment 167230 [details]
Patch

Comment 2 Hajime Morrita 2012-10-04 19:56:33 PDT

Created attachment 167237 [details]
Patch

Comment 3 Early Warning System Bot 2012-10-04 20:16:00 PDT

Comment on attachment 167237 [details]
Patch

Attachment 167237 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14168571

Comment 4 Hajime Morrita 2012-10-04 21:17:11 PDT

Created attachment 167242 [details]
Patch

Comment 5 Dimitri Glazkov (Google) 2012-10-04 21:22:06 PDT

Comment on attachment 167242 [details]
Patch

please make sure it builds before landing.

Comment 6 Hajime Morrita 2012-10-04 21:25:35 PDT

> (From update of attachment 167242 [details])
> please make sure it builds before landing.
Thanks for quick r+. I'm waiting for the greenness.

Comment 7 WebKit Review Bot 2012-10-04 23:15:12 PDT

Comment on attachment 167242 [details]
Patch

Clearing flags on attachment: 167242

Committed r130465: <http://trac.webkit.org/changeset/130465>

Comment 8 WebKit Review Bot 2012-10-04 23:15:17 PDT

All reviewed patches have been landed.  Closing bug.