Bug 98468 - [chromium] Scale plugin container by frameScaleFactor
Summary: [chromium] Scale plugin container by frameScaleFactor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandre Elias
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-04 17:21 PDT by Alexandre Elias
Modified: 2012-10-04 21:14 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2012-10-04 17:22 PDT, Alexandre Elias 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Elias 2012-10-04 17:21:36 PDT 
[chromium] Scale plugin container by frameScaleFactor
Comment 1 Alexandre Elias 2012-10-04 17:22:55 PDT 
Created attachment 167212 [details]
Patch
Comment 2 Adam Barth 2012-10-04 17:31:53 PDT 
Comment on attachment 167212 [details]
Patch

Have you checked that this is still an issue?
Comment 3 Alexandre Elias 2012-10-04 17:33:15 PDT 
Yes.  I was going to delete it but it turned out to still be needed.
Comment 4 Adam Barth 2012-10-04 17:33:20 PDT 
Comment on attachment 167212 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167212&action=review

> Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:121
> +    scaledDamageRect.scale(frameScaleFactor);
> +    scaledDamageRect.move(-frameRect().x() * (frameScaleFactor - 1), -frameRect().y() * (frameScaleFactor - 1));

Is there a function on mainFrame that can do this math for us?  It seems strange for everyone who needs to transform a rect by the frame scale factor to do all this work.
Comment 5 Adam Barth 2012-10-04 17:34:10 PDT 
Comment on attachment 167212 [details]
Patch

Thanks for the patch.  Please consider the comment above before landing.
Comment 6 Alexandre Elias 2012-10-04 17:44:40 PDT 
Comment on attachment 167212 [details]
Patch

This is the only instance of this pattern because it's a non-absolute coordinate, so I don't think it's worth a general method.  Thanks, submitting.
Comment 7 WebKit Review Bot 2012-10-04 21:14:30 PDT 
Comment on attachment 167212 [details]
Patch

Clearing flags on attachment: 167212

Committed r130455: <http://trac.webkit.org/changeset/130455>
Comment 8 WebKit Review Bot 2012-10-04 21:14:34 PDT 
All reviewed patches have been landed.  Closing bug.