Bug 98468 – [chromium] Scale plugin container by frameScaleFactor

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alexandre Elias]

[chromium] Scale plugin container by frameScaleFactor

[Alexandre Elias]

Created attachment 167212 [details]
Patch

[Adam Barth]

Comment on attachment 167212 [details]
Patch

Have you checked that this is still an issue?

[Alexandre Elias]

Yes.  I was going to delete it but it turned out to still be needed.

[Adam Barth]

Comment on attachment 167212 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167212&action=review

> Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:121
> +    scaledDamageRect.scale(frameScaleFactor);
> +    scaledDamageRect.move(-frameRect().x() * (frameScaleFactor - 1), -frameRect().y() * (frameScaleFactor - 1));

Is there a function on mainFrame that can do this math for us?  It seems strange for everyone who needs to transform a rect by the frame scale factor to do all this work.

[Adam Barth]

Comment on attachment 167212 [details]
Patch

Thanks for the patch.  Please consider the comment above before landing.

[Alexandre Elias]

Comment on attachment 167212 [details]
Patch

This is the only instance of this pattern because it's a non-absolute coordinate, so I don't think it's worth a general method.  Thanks, submitting.

[WebKit Review Bot]

Comment on attachment 167212 [details]
Patch

Clearing flags on attachment: 167212

Committed r130455: <http://trac.webkit.org/changeset/130455>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.