Bug 98459 - [Chromium] Improve SocketStreamHandle::send() stability
Summary: [Chromium] Improve SocketStreamHandle::send() stability
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenichi Ishibashi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-04 16:00 PDT by Kenichi Ishibashi
Modified: 2012-10-04 23:39 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.78 KB, patch)
2012-10-04 16:06 PDT, Kenichi Ishibashi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenichi Ishibashi 2012-10-04 16:00:40 PDT
It's not often, but it seems that m_socket can be null in SocketStreamHandle::send(). It should not be NULL there, but for stability, we are going to add a null check. See http://code.google.com/p/chromium/issues/detail?id=153440 more details.
Comment 1 Kenichi Ishibashi 2012-10-04 16:06:25 PDT
Created attachment 167195 [details]
Patch
Comment 2 Yuta Kitamura 2012-10-04 19:17:11 PDT
Comment on attachment 167195 [details]
Patch

Looks OK.
Comment 3 Kenichi Ishibashi 2012-10-04 19:22:24 PDT
Comment on attachment 167195 [details]
Patch

Thank you for review!
Comment 4 WebKit Review Bot 2012-10-04 20:57:35 PDT
Comment on attachment 167195 [details]
Patch

Rejecting attachment 167195 [details] from commit-queue.

New failing tests:
fast/images/paint-subrect-grid.html
Full output: http://queues.webkit.org/results/14176352
Comment 5 WebKit Review Bot 2012-10-04 23:39:11 PDT
Comment on attachment 167195 [details]
Patch

Clearing flags on attachment: 167195

Committed r130468: <http://trac.webkit.org/changeset/130468>
Comment 6 WebKit Review Bot 2012-10-04 23:39:14 PDT
All reviewed patches have been landed.  Closing bug.