Bug 98454 - Split the intrinsic padding update code out of RenderTableSection::layoutRows
Summary: Split the intrinsic padding update code out of RenderTableSection::layoutRows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-04 15:13 PDT by Julien Chaffraix
Modified: 2012-10-04 21:10 PDT (History)
4 users (show)

See Also:

Attachments
Proposed split. Cleaned up a little layoutRows while touching it. (9.47 KB, patch)
2012-10-04 15:36 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2012-10-04 15:13:44 PDT 
RenderTableSection::layoutRows is very long and it's difficult to see what's going on.

The idea of this bug is to split the part about setting the cell's intrinsic padding and move it to RenderTableCell as there is little dependency on RenderTableSection.

Patch forthcoming.
Comment 1 Eric Seidel (no email) 2012-10-04 15:15:51 PDT 
And how!
Comment 2 Julien Chaffraix 2012-10-04 15:36:58 PDT 
Created attachment 167189 [details]
Proposed split. Cleaned up a little layoutRows while touching it.
Comment 3 Eric Seidel (no email) 2012-10-04 19:41:13 PDT 
Comment on attachment 167189 [details]
Proposed split. Cleaned up a little layoutRows while touching it.

Fantastic. :)
Comment 4 WebKit Review Bot 2012-10-04 21:10:15 PDT 
Comment on attachment 167189 [details]
Proposed split. Cleaned up a little layoutRows while touching it.

Clearing flags on attachment: 167189

Committed r130454: <http://trac.webkit.org/changeset/130454>
Comment 5 WebKit Review Bot 2012-10-04 21:10:19 PDT 
All reviewed patches have been landed.  Closing bug.