RESOLVED FIXED 98454
Split the intrinsic padding update code out of RenderTableSection::layoutRows 
https://bugs.webkit.org/show_bug.cgi?id=98454
Summary Split the intrinsic padding update code out of RenderTableSection::layoutRows
Julien Chaffraix
Reported 2012-10-04 15:13:44 PDT
RenderTableSection::layoutRows is very long and it's difficult to see what's going on. The idea of this bug is to split the part about setting the cell's intrinsic padding and move it to RenderTableCell as there is little dependency on RenderTableSection. Patch forthcoming.
Attachments
Proposed split. Cleaned up a little layoutRows while touching it. (9.47 KB, patch)
2012-10-04 15:36 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2012-10-04 15:15:51 PDT
And how!
Julien Chaffraix
Comment 2 2012-10-04 15:36:58 PDT
Created attachment 167189 [details] Proposed split. Cleaned up a little layoutRows while touching it.
Eric Seidel (no email)
Comment 3 2012-10-04 19:41:13 PDT
Comment on attachment 167189 [details] Proposed split. Cleaned up a little layoutRows while touching it. Fantastic. :)
WebKit Review Bot
Comment 4 2012-10-04 21:10:15 PDT
Comment on attachment 167189 [details] Proposed split. Cleaned up a little layoutRows while touching it. Clearing flags on attachment: 167189 Committed r130454: <http://trac.webkit.org/changeset/130454>
WebKit Review Bot
Comment 5 2012-10-04 21:10:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.