Bug 98445 - [V8] NotificationCenter leaks because it uses buggy custom bindings
Summary: [V8] NotificationCenter leaks because it uses buggy custom bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-04 13:25 PDT by Adam Barth
Modified: 2012-10-04 19:18 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.67 KB, patch)
2012-10-04 13:25 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-10-04 13:25:02 PDT
[V8] NotificationCenter leaks because it uses buggy custom bindings
Comment 1 Adam Barth 2012-10-04 13:25:35 PDT
Created attachment 167164 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-04 17:36:59 PDT
Comment on attachment 167164 [details]
Patch

Rejecting attachment 167164 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ng Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Unreviewed, rolling out r130419.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/14178263
Comment 3 WebKit Review Bot 2012-10-04 19:05:39 PDT
Comment on attachment 167164 [details]
Patch

Rejecting attachment 167164 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
hangeLog
Failed to merge in the changes.
Patch failed at 0001 Font::glyphDataAndPageForCharacter doesn't account for text orientation when using systemFallback on a cold cache.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/14181198
Comment 4 Adam Barth 2012-10-04 19:18:25 PDT
Comment on attachment 167164 [details]
Patch

Clearing flags on attachment: 167164

Committed r130446: <http://trac.webkit.org/changeset/130446>
Comment 5 Adam Barth 2012-10-04 19:18:27 PDT
All reviewed patches have been landed.  Closing bug.