Bug 98444 - Removing the unused member variable m_wasMalformed from HTMLFormElement class and its related code frgment.
Summary: Removing the unused member variable m_wasMalformed from HTMLFormElement class...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Pravin D
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-04 13:24 PDT by Pravin D
Modified: 2012-10-04 21:59 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.58 KB, patch)
2012-10-04 16:27 PDT, Pravin D 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pravin D 2012-10-04 13:24:33 PDT 
HTMLFormElement class contains a private member m_wasMalformed. Initial botton margin was supposed to be handled separately for malformed <form> tags. However currently this variable is not being set(effectly not used by any code). Also HTML5 spec does mention anything regarding bottom margin handling for malformed <form>. 
Also see 
https://bugs.webkit.org/show_bug.cgi?id=86746#c9
https://bugs.webkit.org/show_bug.cgi?id=86746#c10

As the code related to m_wasMalformed currently does not have any notable use it can be safely removed.
Comment 1 Pravin D 2012-10-04 16:27:20 PDT 
Created attachment 167199 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-04 21:08:09 PDT 
Comment on attachment 167199 [details]
Patch

Rejecting attachment 167199 [details] from commit-queue.

New failing tests:
fast/images/paint-subrect-grid.html
Full output: http://queues.webkit.org/results/14175376
Comment 3 WebKit Review Bot 2012-10-04 21:59:39 PDT 
Comment on attachment 167199 [details]
Patch

Clearing flags on attachment: 167199

Committed r130461: <http://trac.webkit.org/changeset/130461>
Comment 4 WebKit Review Bot 2012-10-04 21:59:42 PDT 
All reviewed patches have been landed.  Closing bug.