Bug 98441 – FeatureObserver should distinguish between legacy HTML and text notifications

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

FeatureObserver should distinguish between legacy HTML and text notifications

[Adam Barth]

Created attachment 167158 [details]
Patch

[Adam Barth]

Created attachment 167160 [details]
Patch

[Ojan Vafai]

Comment on attachment 167160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167160&action=review

> Source/WebCore/Modules/notifications/NotificationCenter.idl:42
> +       [V8Custom, V8MeasureAs=LegacyTextNotifications] Notification createNotification(in DOMString iconUrl, in DOMString title, in DOMString body) raises(DOMException);

Are these really legacy? What has replaced them?

[Adam Barth]

(In reply to comment #3)
> (From update of attachment 167160 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167160&action=review
> 
> > Source/WebCore/Modules/notifications/NotificationCenter.idl:42
> > +       [V8Custom, V8MeasureAs=LegacyTextNotifications] Notification createNotification(in DOMString iconUrl, in DOMString title, in DOMString body) raises(DOMException);
> 
> Are these really legacy? What has replaced them?

You just create notification using "new Notification" rather than going through the NotificationCenter factory.

[Adam Barth]

Created attachment 167231 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 167231 [details]
Patch for landing

Rejecting attachment 167231 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
rivedSources03.cpp:66:
out/Release/obj/gen/webcore/bindings/V8NotificationCenter.cpp: In function 'v8::Handle<v8::Value> WebCore::NotificationCenterV8Internal::createNotificationCallback(const v8::Arguments&)':
out/Release/obj/gen/webcore/bindings/V8NotificationCenter.cpp:70: error: 'LegacyTextNotificiations' is not a member of 'WebCore::FeatureObserver'
make: *** [out/Release/obj.target/webcore_bindings/gen/webkit/bindings/V8DerivedSources03.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/14175387

[Adam Barth]

Created attachment 167248 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 167248 [details]
Patch for landing

Clearing flags on attachment: 167248

Committed r130463: <http://trac.webkit.org/changeset/130463>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.