Bug 98432 – [WebKit2] Create an API for adding and removing user stylesheets from a page group

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[WebKit2] Create an API for adding and removing user stylesheets from a page group

[Andy Estes]

Created attachment 167156 [details]
Patch

[Build Bot]

Comment on attachment 167156 [details]
Patch

Attachment 167156 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14171365

[Gyuyoung Kim]

Comment on attachment 167156 [details]
Patch

Attachment 167156 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14178178

[Andy Estes]

Created attachment 167166 [details]
Patch

[Andy Estes]

Comment on attachment 167166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167166&action=review

> Tools/TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:36
> -#import <WebKit2/WKBrowsingContextGroup.h>
> +#import "PlatformUtilities.h"
> +#import <JavaScriptCore/JSRetainPtr.h>
> +#import <JavaScriptCore/JavaScriptCore.h>
> +#import <WebKit2/WKRetainPtr.h>
> +#import <WebKit2/WKSerializedScriptValue.h>
> +#import <WebKit2/WKViewPrivate.h>
> +#import <WebKit2/WebKit2.h>
> +#import <WebKit2/WebKit2_C.h>

This file was added by mistake. I'll remove it before landing.

[Andy Estes]

Comment on attachment 167166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167166&action=review

>> Tools/TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:36
>> +#import <WebKit2/WebKit2_C.h>
> 
> This file was added by mistake. I'll remove it before landing.

Er, these includes, not this file.

[Sam Weinig]

Comment on attachment 167166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167166&action=review

> Source/WebKit2/Shared/ImmutableArray.h:53
> +        return adoptRef(new ImmutableArray(entries, size, /* shouldAdoptReferences */ false));
> +    }
> +    static PassRefPtr<ImmutableArray> adopt(APIObject** entries, size_t size)
> +    {
> +        return adoptRef(new ImmutableArray(entries, size, /* shouldAdoptReferences */ true));
>      }

It would probably be cleaner to do this with a Tag (See RetainPtr for an example of this) since this is always known at compile time.

> Source/WebKit2/Shared/UserContentContainer.cpp:35
> +class UserContentItemMessageEncoder : public UserMessageEncoder<UserContentItemMessageEncoder> {

I don't think this should be using user message coding, since we know the object graph.

[Andy Estes]

Created attachment 167239 [details]
Patch

[Sam Weinig]

Comment on attachment 167239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167239&action=review

> Source/WebKit2/Shared/ImmutableArray.cpp:35
> +ImmutableArray::ImmutableArray(ImmutableArray::AdoptTag, APIObject** entries, size_t size)

I think you can just call it AdoptTag here.

> Source/WebKit2/Shared/ImmutableArray.cpp:43
> +: m_entries(size)

Please indent.

> Source/WebKit2/Shared/UserContentContainer.cpp:89
> +        vector.uncheckedAppend(adoptRef(WebString::create(string).leakRef()));

Is the leakRef() adoptRef() craziness needed here?.  Could you not just do vector.uncheckedAppend(WebString::create(string))?

[Andy Estes]

Committed r130948: <http://trac.webkit.org/changeset/130948>