In order to improve our infrastructure for benchmark-driven development, we should have a centralized method of gathering and logging various statistics about the state of the JS heap. This would allow us to create and to use other tools to analyze the output of the VM after running various workloads. The first two statistics that might be interesting is memory use by JSC and GC pause times. We can control whether this recording happens through the use of the Options class, allowing us to either use environment variables or command line flags.
Created attachment 167148 [details] Patch
Attachment 167148 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/Options.h:178: size_tVal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 167155 [details] Patch
Attachment 167155 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1 Source/JavaScriptCore/runtime/Options.h:178: size_tVal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 167155 [details] Patch Attachment 167155 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14180136
Comment on attachment 167155 [details] Patch Attachment 167155 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14152623
Comment on attachment 167155 [details] Patch Attachment 167155 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14182088
Comment on attachment 167155 [details] Patch Attachment 167155 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14173275
Comment on attachment 167155 [details] Patch Attachment 167155 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14183075
Created attachment 167169 [details] Patch
Comment on attachment 167169 [details] Patch Attachment 167169 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14171396
Comment on attachment 167169 [details] Patch Attachment 167169 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14183108
Created attachment 167184 [details] Patch
Comment on attachment 167184 [details] Patch Attachment 167184 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14181126
Created attachment 167202 [details] Patch
Comment on attachment 167202 [details] Patch Attachment 167202 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14178280
Created attachment 167221 [details] Patch
Comment on attachment 167221 [details] Patch r=me
Comment on attachment 167221 [details] Patch Clearing flags on attachment: 167221 Committed r130520: <http://trac.webkit.org/changeset/130520>
All reviewed patches have been landed. Closing bug.