Bug 98417 – After r130344, OpaqueJSString() creates an empty string which should be a null string

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

The change for https://bugs.webkit.org/show_bug.cgi?id=98300 in changeset r130344: <http://trac.webkit.org/changeset/130344>, changes the default OpaqueJSString constructor to have an empty string.  Before the change this was a null string.

The new default constructor initializes m_string with
    m_string = emptyString();

this should be eliminated.

[Michael Saboff]

Created attachment 167118 [details]
Patch

[WebKit Review Bot]

Comment on attachment 167118 [details]
Patch

Clearing flags on attachment: 167118

Committed r130413: <http://trac.webkit.org/changeset/130413>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Just realized that this should have had an API test.

[Michael Saboff]

There is a second case where we turn a null string into an empty string.  That is when OpaqueJSString(String string) is called and string is null.

If we fail the if (!string.isNull()) check, that is the string is null, we should return 0.

[Geoffrey Garen]

> Just realized that this should have had an API test.

Yes, please add an API test for both identified cases.

[Michael Saboff]

Created attachment 167554 [details]
Patch

Working on API tests, although there isn't a direct way to test the API.  Looking for an indirect method for both checks.

[Michael Saboff]

Committed r130664: <http://trac.webkit.org/changeset/130664>