Bug 98387 - [Qt] GL_ARB_texture_rectangle must be activated when using ANGLE on Mac.
Summary: [Qt] GL_ARB_texture_rectangle must be activated when using ANGLE on Mac.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zeno Albisser
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-04 02:26 PDT by Zeno Albisser
Modified: 2012-10-10 03:38 PDT (History)
3 users (show)

See Also:

Attachments
patch for review. (1.54 KB, patch)
2012-10-04 02:37 PDT, Zeno Albisser 		noam: review-
Details | Formatted Diff | Diff
patch for review. - using Extensions3D. (1.60 KB, patch)
2012-10-05 04:58 PDT, Zeno Albisser 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2012-10-04 02:26:14 PDT 
The GraphicsSurface implementation on Mac is based on an IOSurface.
And IOSurface requires this extension.
So this change is necessary to enable WebGL again after r127063.
Comment 1 Zeno Albisser 2012-10-04 02:37:38 PDT 
Created attachment 167059 [details]
patch for review.
Comment 2 Noam Rosenthal 2012-10-04 07:14:24 PDT 
Comment on attachment 167059 [details]
patch for review.

View in context: https://bugs.webkit.org/attachment.cgi?id=167059&action=review

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:211
> +    if (m_platformContext->hasExtension(QByteArrayLiteral("GL_ARB_texture_rectangle")))
> +        ANGLEResources.ARB_texture_rectangle = 1;

Please use Extensions3D
Comment 3 Zeno Albisser 2012-10-05 04:58:27 PDT 
Created attachment 167309 [details]
patch for review. - using Extensions3D.
Comment 4 Zeno Albisser 2012-10-10 03:38:36 PDT 
Comment on attachment 167309 [details]
patch for review. - using Extensions3D.

Clearing flags on attachment: 167309

Committed r130880: <http://trac.webkit.org/changeset/130880>
Comment 5 Zeno Albisser 2012-10-10 03:38:42 PDT 
All reviewed patches have been landed.  Closing bug.