RESOLVED FIXED 98385
Web Inspector: When uiSourceCode content has diverged from VM script, call frames should be shown in temporary script based uiSourceCodes. 
https://bugs.webkit.org/show_bug.cgi?id=98385
Summary Web Inspector: When uiSourceCode content has diverged from VM script, call fr...
Vsevolod Vlasov
Reported 2012-10-04 01:08:57 PDT
Patch to follow
Attachments
Patch (27.45 KB, patch)
2012-10-04 01:50 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (27.84 KB, patch)
2012-10-04 01:54 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (23.08 KB, patch)
2012-10-04 08:07 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-10-04 01:50:24 PDT
Created attachment 167053 [details] Patch
Vsevolod Vlasov
Comment 2 2012-10-04 01:54:18 PDT
Created attachment 167055 [details] Patch
Pavel Feldman
Comment 3 2012-10-04 02:23:27 PDT
Comment on attachment 167055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167055&action=review > Source/WebCore/ChangeLog:8 > + Introduced uiSourceCode attribute concept and attributeChanged event. Please split this change, it has too many random components. > Source/WebCore/inspector/front-end/DebuggerModel.js:779 > + return this._script.rawLocationToUILocation(this.location.lineNumber, this.location.columnNumber); I think we should either expose live locations or location getters. > Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:163 > + var breakpoints = this._getBreakpointDecorations(); This is quite expensive (you are doing it per key press, right?) no _get prefixes in WebKit > Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:172 > + this._setBreakpointDecorations(breakpoints); You should instead get breakpoints from the vm version of UISourceCode.
Vsevolod Vlasov
Comment 4 2012-10-04 08:07:43 PDT
Created attachment 167107 [details] Patch
Pavel Feldman
Comment 5 2012-10-04 08:11:59 PDT
Comment on attachment 167107 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167107&action=review > Source/WebCore/inspector/front-end/BreakpointManager.js:112 > + if (uiSourceCode.isDivergedReplacement) divergedVersion: function() { return uiSourceCode; } > Source/WebCore/inspector/front-end/JavaScriptSource.js:80 > + fireHasDivergedFromVMChanged: function() I would split it into "fileHasDiverged" and "fileWasMerged"
Vsevolod Vlasov
Comment 6 2012-10-04 08:32:06 PDT
Committed r130393: <http://trac.webkit.org/changeset/130393>
Note You need to log in before you can comment on or make changes to this bug.