Bug 98384 – [WK2][GTK][EFL] standard_output returned by g_spawn_sync must be freed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Sudarsana Nagineni (babu)]

standard_output returned by g_spawn_sync() leaks here if we return early after evaluating the exit status.

http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp#L68

64	    if (!g_spawn_sync(0, argv, 0, G_SPAWN_STDERR_TO_DEV_NULL, 0, 0, &stdOut, 0, &status, 0))
65	        return false;
66	
67	    if (!WIFEXITED(status) || WEXITSTATUS(status) != EXIT_SUCCESS)
68	        return false;

[Sudarsana Nagineni (babu)]

Created attachment 167044 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 167044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167044&action=review

> Source/WebKit2/ChangeLog:3
> +        [WK2] [EFL] standard_output returned by g_spawn_sync must be freed

This is not EFL port patch. Please remove [EFL] keyword.

> Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:68
> +        free(stdOut);

Don't we need to check if stdOut is null once more?

[Sudarsana Nagineni (babu)]

Comment on attachment 167044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167044&action=review

>> Source/WebKit2/ChangeLog:3
>> +        [WK2] [EFL] standard_output returned by g_spawn_sync must be freed
> 
> This is not EFL port patch. Please remove [EFL] keyword.

This code is under GTK/EFL ifdef guards. I think make sense to add GTK too, instead of removing EFL.

>> Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:68
>> +        free(stdOut);
> 
> Don't we need to check if stdOut is null once more?

free is NULL-safe, no need to check.

[Sudarsana Nagineni (babu)]

Created attachment 167278 [details]
Patch

Updated changelog.

[Gyuyoung Kim]

Comment on attachment 167278 [details]
Patch

Looks make sense.

[WebKit Review Bot]

Comment on attachment 167278 [details]
Patch

Clearing flags on attachment: 167278

Committed r130490: <http://trac.webkit.org/changeset/130490>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.