Bug 98369 - [GTK] accessibility/language-attribute.html is failing
: [GTK] accessibility/language-attribute.html is failing
Status: RESOLVED FIXED
: WebKit
WebKit Gtk
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
: Gtk, LayoutTestFailure
:
: 98347
  Show dependency treegraph
 
Reported: 2012-10-04 00:41 PST by
Modified: 2012-12-10 00:18 PST (History)


Attachments
Patch (7.72 KB, patch)
2012-12-09 16:13 PST, Joanmarie Diggs (irc: joanie)
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


------- Comment #1 From 2012-10-16 13:01:04 PST -------
This is failing for two reasons:

* We're not exposing the language for the object (should be an AtkText attribute)
* AccessibilityUIElement::language() needs to be implemented
------- Comment #2 From 2012-12-09 16:13:21 PST -------
Created an attachment (id=178447) [details]
Patch
------- Comment #3 From 2012-12-09 16:40:46 PST -------
(From update of attachment 178447 [details])
EWS all green, small patch, hoping it will pass Martin's review, so cq?ing.
------- Comment #4 From 2012-12-09 23:45:52 PST -------
(From update of attachment 178447 [details])
looks good
------- Comment #5 From 2012-12-10 00:18:53 PST -------
(From update of attachment 178447 [details])
Clearing flags on attachment: 178447

Committed r137114: <http://trac.webkit.org/changeset/137114>
------- Comment #6 From 2012-12-10 00:18:56 PST -------
All reviewed patches have been landed.  Closing bug.