Bug 98364 - [GTK] accessibility/editable-webarea-context-menu-point.html is failing
: [GTK] accessibility/editable-webarea-context-menu-point.html is failing
Status: RESOLVED FIXED
: WebKit
WebKit Gtk
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
: Gtk, LayoutTestFailure
:
: 98347
  Show dependency treegraph
 
Reported: 2012-10-04 00:39 PST by
Modified: 2012-12-10 00:11 PST (History)


Attachments
Patch (14.05 KB, patch)
2012-12-09 04:41 PST, Joanmarie Diggs (irc: joanie)
no flags Review Patch | Details | Formatted Diff | Diff
Patch (14.24 KB, patch)
2012-12-09 05:46 PST, Joanmarie Diggs (irc: joanie)
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


------- Comment #1 From 2012-10-17 05:24:19 PST -------
Definitely will require implementing AccessibilityUIElement::clickPointX(). Whether or not that will be sufficient to make this test pass remains to be seen.
------- Comment #2 From 2012-12-09 04:41:26 PST -------
Created an attachment (id=178410) [details]
Patch
------- Comment #3 From 2012-12-09 04:43:51 PST -------
Chris: This patch just moves the failing test to the Mac platform as it seems to be mac-specific. I already checked with Mario and he agrees.

Please review. Thanks in advance!
------- Comment #4 From 2012-12-09 05:15:53 PST -------
(From update of attachment 178410 [details])
Attachment 178410 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15222297

New failing tests:
platform/mac/accessibility/editable-webarea-context-menu-point.html
------- Comment #5 From 2012-12-09 05:34:36 PST -------
I'm assuming that the failure on the mac is due to the fact that I'm moving the test, rather than a real failure.(?)
------- Comment #6 From 2012-12-09 05:46:18 PST -------
Created an attachment (id=178414) [details]
Patch
------- Comment #7 From 2012-12-09 23:40:05 PST -------
(From update of attachment 178414 [details])
click point on the mac is just the center point of the bounding box. maybe there's something else that makes that hard to get to
------- Comment #8 From 2012-12-10 00:05:48 PST -------
(From update of attachment 178414 [details])
Clearing flags on attachment: 178414

Committed r137113: <http://trac.webkit.org/changeset/137113>
------- Comment #9 From 2012-12-10 00:05:53 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #10 From 2012-12-10 00:11:44 PST -------
(In reply to comment #7)
> (From update of attachment 178414 [details] [details])
> click point on the mac is just the center point of the bounding box. maybe there's something else that makes that hard to get to

Aha! I didn't know about the bounding box. Bounding boxes I can get and center point I can calculate. Not sure if that makes this patch rollout-worthy....